Dots in project names automatically parametrized.
Created by: victorcoder
Hi,
we just upgraded to 4.1 and we are used to name our repos with the client domain name, client.com, etc.
With 3.1 version we just were happy with the two textboxes that allows us to modify repo path and url, changing the suggested "_" for our preferred "."
But with this version, there's no more those textboxes. We were happy with that freedom to choose, and all our existing repos are working just find in 4.1 but new repos are being created with dashes "-" instead of dots "."
This is enforced here: https://github.com/gitlabhq/gitlabhq/blob/master/app/contexts/projects/create_context.rb#L13-L18
My question is, should be possible to restore back the old textboxes or it's dangerous for some reason to allow dots in pathnames and or urls inside gitlab?
Thanks.
Activity
Created by: dzaporozhets
we switched to parametrized algorithm in order to prevent any problems with validating path and parsing project url. I agree that freedom of choise is improtant. But sometimes we use simplest solution to prevent bugs in future.
You can fork and restore old checkboxes but then we cannot guarantee a stability of application. It just may cause bugs
By Administrator on 2013-01-24T21:04:38 (imported from GitLab)
Created by: victorcoder
Thanks @randx I noticed that namespaced existing users is using email address and in my case we have everybody with dots in emails so the generater namespace urls could suffer from the same problem. Should be more consistent to parametrize namespaces too.
@koenpunt +1 My first action was to look at the config file.
By Administrator on 2013-01-24T22:06:19 (imported from GitLab)
Created by: koenpunt
And speaking of the project path, my issue (#1143 (closed)) also still exists
By Administrator on 2013-01-28T11:45:52 (imported from GitLab)
