Closing issue via API indicates wrong user performing the action

Created by: mphuff

We are using version 4.0 of Gitlab. Below are a set of curl commands to demonstrate the functionality I am describing. Assume that I have the following setup:

Issue ID: 47 Project ID: 96 Private token: JyrMpqSeNUoYqXehFmt3

The following commands will demonstrate this problem.

# Adding a note to this existing issue will indicate that I created the note:
curl -d "body=This is a note to show that the proper user is tagged for the issue note" http://<MY GITLAB SERVER>/api/v3/projects/96/issues/49/notes?private_token=JyrMpqSeNUoYqXehFmt3
# Closing this issue through the API will mark this as closed by a different user
curl -X PUT -d "closed=1" http://<MY GITLAB SERVER>/api/v3/projects/96/issues/49?private_token=JyrMpqSeNUoYqXehFmt3

You can see the issue in the picture below. My API key corresponds to the person "Micah Huff".

This is obviously a critical issue as the incorrect user is being tagged as having done some work in the system.

Thank you, Micah

Created by: m4tthumphrey

I had also noticed this happening before but I have just checked again it looks like it may have been fixed in 4.1.

By Administrator on 2013-01-28T09:51:47 (imported from GitLab)

Created by: mphuff

This looks like it may have resolved the issue but I can't be sure as of yet as I don't have a 4.1 Gitlab install up and running...can anybody verify for 100% certainty that this is resolved?

git diff origin/4-0-stable origin/4-1-stable lib/api/issues.rb
diff --git a/lib/api/issues.rb b/lib/api/issues.rb
index 3be5588..4d832fb 100644
--- a/lib/api/issues.rb
+++ b/lib/api/issues.rb
@@ -78,6 +78,7 @@ module Gitlab

         attrs = attributes_for_keys [:title, :description, :assignee_id, :milestone_id, :closed]
         attrs[:label_list] = params[:labels] if params[:labels].present?
+        IssueObserver.current_user = current_user
         if @issue.update_attributes attrs
           present @issue, with: Entities::Issue
         else

By Administrator on 2013-01-28T21:00:10 (imported from GitLab)

Created by: weisjohn

I've seen this in 4.0 as well.

By Administrator on 2013-01-29T21:37:09 (imported from GitLab)

Created by: m4tthumphrey

I'm convinced this has been fixed.

By Administrator on 2013-03-12T15:18:27 (imported from GitLab)

Created by: mphuff

I believe it has as well. Please close.

• Micah

On Mar 12, 2013, at 8:19 AM, Matt Humphrey notifications@github.com wrote:

I'm convinced this has been fixed.

— Reply to this email directly or view it on GitHub.

By Administrator on 2013-03-12T15:39:03 (imported from GitLab)