Close issues via commit message

Created by: dfyx

Very important feature, thumbs up!

By Administrator on 2012-01-17T17:52:13 (imported from GitLab)

Created by: jpsirois

I agree

By Administrator on 2012-01-25T23:05:13 (imported from GitLab)

Created by: garnieretienne

Me too, like it !

By Administrator on 2012-01-29T00:28:30 (imported from GitLab)

Created by: chibani

+1 , it would be great :)

By Administrator on 2012-02-05T10:46:06 (imported from GitLab)

Created by: bostondv

Add refs #xxx also, to link a commit without closing it.

By Administrator on 2012-02-12T17:21:06 (imported from GitLab)

Created by: jpsirois

I think just #xxx without any keywords should reference to it.

By Administrator on 2012-02-13T14:49:17 (imported from GitLab)

Created by: zedtux

+1 important feature!

By Administrator on 2012-03-05T09:04:13 (imported from GitLab)

Created by: arnaudbos

+1, like this feature on Github.

By Administrator on 2012-03-05T09:09:41 (imported from GitLab)

Created by: zedtux

To be honest, if this feature is implemented soon, my company could implement it has ticketing system for all our projects!

So please, could you focus on this issue ?

By Administrator on 2012-03-05T10:55:42 (imported from GitLab)

Created by: steakknife

Would really like this. I mean, I can do it in JIRA and Redmine even.

By Administrator on 2012-03-07T11:43:40 (imported from GitLab)

Created by: chenshan

+1

By Administrator on 2012-03-30T03:41:37 (imported from GitLab)

Created by: dubcanada

This will be added to the labels/milestone part of the comments. Which is set for 2.4 (thought it may not make it till 2.5)

By Administrator on 2012-03-30T04:38:31 (imported from GitLab)

Created by: steakknife

class GitHubCommitMessage
.
.
.
  # issues that this commit msg closes.
  #
  # returns an array of issue #'s, or an empty array if no match.
  #
  def closes_any_issues?
    @commit_msg.scan(/(?:(?:fix|clos)(?:e[ds]?)?)\s*#\s*([1-9][0-9]*)+/i).flatten.map(&:to_i)
  end

  # issues that this commit msg refers to (not counting fixing/closing).
  #
  # returns an array of issue #'s, or an empty array if no match.
  #
  def refers_to_any_issues?
    @commit_msg.scan(/(?:(?:ref(?:er)?s?)\s*#\s*([1-9][0-9]*))+/i).flatten.map(&:to_i)
  end
.
.
.
end

# feel free to add specs

By Administrator on 2012-03-30T11:28:32 (imported from GitLab)

Created by: dubcanada

Nvm, it seems this was already done #604

By Administrator on 2012-03-30T19:59:02 (imported from GitLab)

Created by: steakknife

Win. 🍰

By Administrator on 2012-03-31T12:16:40 (imported from GitLab)

Created by: zedtux

Nice!! Thanks!

By Administrator on 2012-03-31T17:53:12 (imported from GitLab)

Created by: riyad

#527 (closed) generalizes the concept and goes a bit further.

By Administrator on 2012-04-18T10:19:04 (imported from GitLab)

Created by: riyad

FYI this issue is being discussed in #1170 (closed) in more detail

By Administrator on 2012-08-24T00:51:05 (imported from GitLab)

Created by: deanpcmad

Has this been done at all? It's one thing that is preventing me from moving to Gitlab :)

By Administrator on 2012-08-26T17:29:08 (imported from GitLab)

Created by: maskedinterrupt

+1 This would be very nice. A setting to make it dependent on the branch that it was pushed to would be awesome, so for example only commits merged into master could close issues.

By Administrator on 2012-09-20T18:46:07 (imported from GitLab)

Created by: rajeshmeniya

Good feature, like it...

By Administrator on 2012-10-19T04:43:18 (imported from GitLab)

Created by: Trontastic

+1

By Administrator on 2012-10-21T10:05:18 (imported from GitLab)

Created by: xkrys

+1

By Administrator on 2012-11-15T00:27:01 (imported from GitLab)

Created by: thomasdavis

+2

By Administrator on 2012-11-26T01:37:32 (imported from GitLab)

Created by: sriharshav

+1

By Administrator on 2012-11-26T18:40:48 (imported from GitLab)

Created by: ahall

+1

By Administrator on 2013-01-08T10:31:19 (imported from GitLab)

Created by: detj

For the past few weeks, I'm not able to close issues from commit messages. I've tried

Fixes #xxx
Fix #xxx
Closes #xxx
Close #xxx

Has this been temporarily disabled?

By Administrator on 2013-01-10T20:52:08 (imported from GitLab)

Created by: tvb

@detj afaik it has not been implemented yet in gitlab (but it does work in github ofcourse)

By Administrator on 2013-01-11T13:38:35 (imported from GitLab)

Created by: christopherraa

Currently not working for me either. Does it matter if the commit in question is not to master but to a branch?

By Administrator on 2013-01-12T15:09:06 (imported from GitLab)

Created by: weisjohn

Please look here: https://github.com/gitlabhq/gitlab-public-wiki/wiki/Hooks

By Administrator on 2013-01-12T17:59:46 (imported from GitLab)

Created by: thomas-lebeau

👍 +1

By Administrator on 2013-02-14T09:50:23 (imported from GitLab)

Created by: samba

👍 - definitely something I'd prefer to see supported within GitLab, not as a Git hook.

In our case, the web API in accessible from many locations due to network policy, while the SSH access is permitted due to there being key-based authentication. Using hooks is infeasible for us.

By Administrator on 2013-02-15T03:35:04 (imported from GitLab)

Created by: caioariede

👍

By Administrator on 2013-03-21T15:36:14 (imported from GitLab)

Created by: senny

Hey guys

Thanks for your interest in GitLab ❤️

We don't use the Github issue tracker for feature requests. Please use http://feedback.gitlab.com/ for this purpose. Have a look at the contribution guidelines for more information.

This seems to be something that many are waiting for. Please head over to the feedback app and vote for this request: http://feedback.gitlab.com/forums/176466-general/suggestions/3692754-linking-issue-references

By Administrator on 2013-04-19T10:02:25 (imported from GitLab)

Created by: bbilginn

Closed push on new branch Closed #XX does not work?

By Administrator on 2014-03-19T15:39:32 (imported from GitLab)

Close issues via commit message

Designs

Child items 0

Activity

Admin message

Admin message

Close issues via commit message

Activity