Can not browse project files
Created by: Andrepuel
I am having an issue browsing the files of a project.
When I open (for example), the project in3d/uml in the files tab. The code loads a javascript code in3d/uml/refs/master/logs_tree/?_=1366661003595. Which returns error 500.
My production log says:
ActionView::Template::Error (undefined method `committed_date' for nil:NilClass):
4:
5: :plain
6: var row = $("table.table_#{@hex_path} tr.file_#{hexdigest(file_name)}");
7: row.find("td.tree_time_ago").html('#{escape_javascript time_ago_in_words(commit.committed_date)} ago');
8: row.find("td.tree_commit").html('#{escape_javascript render("tree/tree_commit_column", commit: commit)}');
app/views/refs/logs_tree.js.haml:7:in `block in _app_views_refs_logs_tree_js_haml__2165738030098632402_36915080'
app/views/refs/logs_tree.js.haml:1:in `each'
app/views/refs/logs_tree.js.haml:1:in `_app_views_refs_logs_tree_js_haml__2165738030098632402_36915080'I am using the master branch.
Activity
Created by: Deradon
Same here.
Some digging:
ActionView::Template::Error ({:file_name=>".autotest", :commit=>nil}): 1: - @logs.each do |content_data| 2: - file_name = content_data[:file_name] 3: - commit = content_data[:commit] 4: - raise "#{content_data.inspect}" 5: 6: :plain 7: var row = $("table.table_#{@hex_path} tr.file_#{hexdigest(file_name)}"); app/views/refs/logs_tree.js.haml:4:in `block in _app_views_refs_logs_tree_js_haml___3669385153660652018_48202680'By Administrator on 2013-04-22T20:08:23 (imported from GitLab)
Created by: Razer6
Duplicate of #3614 (closed)
By Administrator on 2013-04-22T20:10:34 (imported from GitLab)
Created by: Deradon
This commit breaks it for me: https://github.com/gitlabhq/gitlabhq/commit/b1a8fdd84d5a7cdbdb5ef3829b59a73db0f4d2dd
Everythin is working, when I revert this.
By Administrator on 2013-04-22T21:39:08 (imported from GitLab)
Created by: Deradon
Digging deep into the code and running queries on
rails concole. I noticed thatproject.repository.commitsdid not worked as expected.And finally, just watched the history of
lib/gitlab/git/repository.rb.By Administrator on 2013-04-22T21:47:55 (imported from GitLab)
Created by: Andrepuel
@Deradon Yes. Right, switching branch on a file gives an 500 error.
By the way, about the b1a8fdd8 commit. Only the
follow: truepart of it caused the bug.By Administrator on 2013-04-22T22:19:14 (imported from GitLab)
Created by: Deradon
Hotfixed the file switchin issue.
On
app/views/blob/show.html.hamlchange:- = render 'shared/ref_switcher', destination: 'tree', path: @path + = render 'shared/ref_switcher', destination: 'blob', path: @pathAnd on
app/controllers/refs_controller.rbformat.html do new_path = if params[:destination] == "tree" project_tree_path(@project, (@ref + "/" + params[:path])) + elsif params[:destination] == "blob" + project_blob_path(@project, (@ref + "/" + params[:path])) elsif params[:destination] == "graph" project_graph_path(@project, @ref) elseBy Administrator on 2013-04-22T22:26:43 (imported from GitLab)
Created by: waldvogel
@hiroponz did you mean that browsing the files gives 404 when starting puma via "service"?
By Administrator on 2013-04-23T08:48:20 (imported from GitLab)
Created by: hiroponz
@Waldvogel browsing the files gives 500 when starting puma via "service", but it looks good when starting via "raw command". @Akzhan it seems that the problem remains in latest master(b5461e0c).
By Administrator on 2013-04-23T09:09:47 (imported from GitLab)
Created by: akzhan
Please take a look at https://github.com/akzhan/gitlabhq/commit/33a10748380f9d8879855d3b1237120d8ac3ce9d
It should fix this issue.
Will add PR in minutes if it helps.
By Administrator on 2013-04-23T12:21:50 (imported from GitLab)
Created by: hiroponz
It seems that this problem has relevance to the version of git. Internal git command called when showing the files is the following. It shows no result if the version of git is 1.7.1(default of CentOS6).
/usr/bin/git --git-dir=/home/git/repositories/config.git log --pretty=raw --max-count=1 --skip= --follow 1e1741baaef56f8812982df2f309368d21eb7f35 -- vimrcOtherwise the following command shows the expected result. "/usr/local/bin/git" is installed from source and the version is 1.8.2.
/usr/local/bin/git --git-dir=/home/git/repositories/config.git log --pretty=raw --max-count=1 --skip= --follow 1e1741baaef56f8812982df2f309368d21eb7f35 -- vimrcIt seems that "/usr/bin/git" is used when gitlab starts via
sudo service gitlab start, but also "/usr/local/bin/git" is used when gitlab starts viasudo -u git -H bundle exec puma -C config/puma.rb -e productionin the gitlab directory. UPDATE: It is simply a difference of PATH environment.Sorry, my English may be confusing.
By Administrator on 2013-04-24T00:43:45 (imported from GitLab)
Created by: waldvogel
@hiroponz right, it seems to be the git version then, Git on my server is 1.7.2.5 . Upgraded to 1.7.10.4 and everything suddenly works without any patches.
By Administrator on 2013-04-23T19:04:23 (imported from GitLab)
Created by: untergeek
Upgrading to git 1.8.7 did not fix for me, even when combined with 33a10748. Reverting b1a8fdd8 as @Deradon suggests did fix. Also, there will be a LOT of people using RHEL or CentOS (even 6.4) which are using 1.7.1. If the eventual resolution is going to force upgrades it could get ugly.
By Administrator on 2013-04-25T17:23:13 (imported from GitLab)
Created by: fredowski
Hi, i had the problem with debian squeeze that I could not browse the files correctly. I have only a very small repository for testing here. The toplevel readme.md was shown but I could not browse the src directory with the hello.c file. You can see and browse the project here https://git.etech.fh-augsburg.de as I added the public view from https://github.com/ArthurHoaro/Public-GitLab
I use gitlab version 5.1. Debian Squeeze base installation has
fritz@git:~$ git --version git version 1.7.2.5I upgraded the git version from the backports packages
fritz@git:/etc/apt$ sudo service nginx stop Stopping nginx: nginx. fritz@git:/etc/apt$ sudo service gitlab stop Gitlab service stopped fritz@git:/etc/apt$ sudo apt-get -t squeeze-backports install gitand now I have
fritz@git:/etc/apt$ git --version git version 1.7.10.4With this version I can browse the src directory and view the hello.c file. The production.log showed the following problem:
BEFORE upgrading git
Started GET "/friedrich.beckmann/myfirst/refs/master/logs_tree/?_=1367233301630" for at 2013-04-29 13:01:39 +0200 Processing by RefsController#logs_tree as JS Parameters: {"_"=>"1367233301630", "project_id"=>"friedrich.beckmann/myfirst", "id"=>"master"} Rendered refs/logs_tree.js.haml (1.7ms) Completed 500 Internal Server Error in 277ms ActionView::Template::Error (undefined method `committed_date' for nil:NilClass): 4: 5: :plain 6: var row = $("table.table_#{@hex_path} tr.file_#{hexdigest(file_name)}"); 7: row.find("td.tree_time_ago").html('#{escape_javascript time_ago_in_words(commit.committed_date)} ago'); 8: row.find("td.tree_commit").html('#{escape_javascript render("tree/tree_commit_column", commit: commit)}'); app/views/refs/logs_tree.js.haml:7:in `block in _app_views_refs_logs_tree_js_haml__4535212803205513496_65539860' app/views/refs/logs_tree.js.haml:1:in `each' app/views/refs/logs_tree.js.haml:1:in `_app_views_refs_logs_tree_js_haml__4535212803205513496_65539860'AFTER upgrading git it shows
Started GET "/friedrich.beckmann/myfirst/refs/master/logs_tree/?_=1367235514796" for at 2013-04-29 13:38:32 +0200 Processing by RefsController#logs_tree as JS Parameters: {"_"=>"1367235514796", "project_id"=>"friedrich.beckmann/myfirst", "id"=>"master"} Rendered tree/_tree_commit_column.html.haml (6.3ms) Rendered tree/_tree_commit_column.html.haml (3.5ms) Rendered refs/logs_tree.js.haml (12.7ms) Completed 200 OK in 261ms (Views: 14.0ms | ActiveRecord: 1.5ms)By Administrator on 2013-04-29T11:56:19 (imported from GitLab)
Created by: KittMedia
Same here. Before upgrading git to 1.7.10.4 on Debian Squeeze, neither last update nor last commit was displayed. Now the only thing that doesn't work is if you want to watch a file directly.
Log:
Started GET "/Project/teaserbox/blob/master/de.xml" for at 2013-05-15 21:02:53 +0200 Processing by BlobController#show as HTML Parameters: {"project_id"=>"Project/teaserbox", "id"=>"master/de.xml"} Rendered shared/_ref_switcher.html.haml (2.9ms) Rendered blob/_actions.html.haml (13.5ms) Rendered blob/_text.html.haml (104.3ms) Rendered blob/_blob.html.haml (121.4ms) Rendered blob/show.html.haml within layouts/project_resource (125.2ms) Completed 500 Internal Server Error in 173ms ActionView::Template::Error (Failed to get header.): 9: .file_content.code 10: - unless blob.empty? 11: %div{class: user_color_scheme_class} 12: = raw blob.colorize(formatter: :gitlab) 13: - else 14: %p.nothing_here_message Empty file app/views/blob/_text.html.haml:12:in `_app_views_blob__text_html_haml__2483801088153950546_26695420' app/views/blob/_blob.html.haml:23:in `_app_views_blob__blob_html_haml__4147036798351228764_51988220' app/views/blob/show.html.haml:4:in `_app_views_blob_show_html_haml___2010798707396750319_50296940'By Administrator on 2013-05-15T19:09:14 (imported from GitLab)
Created by: jph
I can confirm that upgrading git from version 1.7.2.5 to 1.7.10.4 fixes the issue of loading commit data. The issue appeared after upgrading from 3.1 to 5.1.0 following the update markdown howtos.
It would be nice if there wasn't a forced update but it's a minor issue overall.
By Administrator on 2013-05-16T00:50:40 (imported from GitLab)
