Can't read code on public projects

Created by: yosiat

Hi, I have public project and from guest users I can't see the files tab, is this alright?

It seems very strange.. public project I should be able to read the project the code, and I saw that code that public project I can't fork and download it's code...

It pretty much weird...

Created by: dplarson

I thought marking a project as public only allowed cloning the repository without authentication and did not enable access to any of the Gitlab web-interface.

By Administrator on 2013-06-01T04:24:08 (imported from GitLab)

Created by: yosiat

What is the reason behind this? Think.. if the user can clone your project - Here can read your code and see your history - Why not do it from Gitlab web interface?

By Administrator on 2013-06-01T16:51:20 (imported from GitLab)

Created by: dplarson

I think it's partly a technical issue (how to provide unauthenticated web access while keeping everything secure), but I think it was also a design choice. After all, Gitlab is meant for private hosting while there are already good options for public hosting (e.g. Github).

By Administrator on 2013-06-01T18:19:00 (imported from GitLab)

Created by: yosiat

In my opinion gitlab is meant for organizations, organization code collaboration dosen't differ from the outside, In the organization you have private projects and public projects as well which you fork and submit pull request.

Gitlab core team, what do you think? In my opinion - user should be able read the code, download the code and fork a public project. I can submit a pull request for that.

By Administrator on 2013-06-01T18:39:50 (imported from GitLab)

Created by: dplarson

I think your definition of a public project is different than the current one in Gitlab:

1. current definition of "public": accessible to anyone with the URL (no account or authentication required)
2. your proposed definition of "public": accessible to anyone with an account on the Gitlab server

I agree that definition 2 would be a nice feature in Gitlab. And you're willing to make a pull request adding that feature, then more power to you.

By Administrator on 2013-06-01T19:33:24 (imported from GitLab)

Created by: axilleas

According to #3801, it should have been the case where you can browse the code. If you append /tree/master to the project url you can see the code. So, this is a bug not showing the Files tab.

By Administrator on 2013-06-02T09:21:31 (imported from GitLab)

Created by: slottermoser

@dplarson #3801 does enable GitLab users to browse a projects pages, create issues, etc. if it is public. This has been merged and is available in GitLab 5.2.

@yosy guest users should be able to see the files tab on a public project. I will check it out after I get some sleep :) Can you verify that you're running GitLab 5.2?

By Administrator on 2013-06-02T09:23:09 (imported from GitLab)

Created by: axilleas

I verify that I cannot see the Files tab on 5.3.0.pre 132575f.

By Administrator on 2013-06-02T09:43:50 (imported from GitLab)

Created by: yosiat

@slottermoser I can verify that I have the problem on Gitlab 5.2 stable and on the master version of gitlab.

The problem is here - https://github.com/gitlabhq/gitlabhq/blob/master/app/models/ability.rb

The download_code and fork_project is under the repoter and not the guest.

By Administrator on 2013-06-04T17:52:33 (imported from GitLab)

Created by: slottermoser

Thanks for fixing this @randx. I like what you did there, breaking out public project permissions into its own specific array. Makes things much clearer.

By Administrator on 2013-06-07T03:15:40 (imported from GitLab)

Created by: yosiat

Hi @randx , thanks for fixing this! I have on question - When merge request between repositories will be added, then use should be able to create merge requests, am I right?

By Administrator on 2013-06-07T22:03:24 (imported from GitLab)