Merge branch 'docs/expand-the-mr-template' into 'master'

Expand the MR Default template with some clarifications

See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6753



Merged-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Approved-by: Dmytro Makovey <dmakovey@gitlab.com>
Approved-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Reviewed-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Co-authored-by: João Cunha <j.a.cunha@gmail.com>

.gitlab/merge_request_templates/Default.md

@@ -14,20 +14,29 @@
 See [Definition of done](https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/CONTRIBUTING.md#definition-of-done).
-For anything in this list which will not be completed, please provide a reason in the MR discussion
+For anything in this list which will not be completed, please provide a reason in the MR discussion.
 ### Required
-- [ ] Merge Request Title, and Description are up to date, accurate, and descriptive
-- [ ] MR targeting the appropriate branch
-- [ ] MR has a green pipeline on GitLab.com
-- [ ] Pipeline is green on the [dev.gitlab.org](https://dev.gitlab.org/gitlab/omnibus-gitlab/-/pipelines) mirror for this branch if the change is touching anything besides documentation or internal cookbooks. Please note that feature branches are not automatically mirrored to dev.gitlab.org, and should be manually pushed whenever necessary.
-- [ ] `trigger-package` has a green pipeline running against latest commit
-- [ ] When ready for review, MR is labeled "~workflow::ready for review" per the [Distribution MR workflow](https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html)
+
+- [ ] MR title and description are up to date, accurate, and descriptive.
+- [ ] MR targeting the appropriate branch.
+- [ ] Latest Merge Result pipeline is green.
+- [ ] When ready for review, MR is labeled "~workflow::ready for review" per the [Distribution MR workflow](https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html).
+
+#### For GitLab team members
+
+If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
+
+- [ ] The manual `Trigger:ee-package` jobs have a green pipeline running against latest commit.
+- [ ] If `config/software` or `config/patches` directories are changed, make sure the `build-package-on-all-os` job within the `Trigger:ee-package` downstream pipeline succeeded.
+- [ ] If you are changing anything SSL related, then the `Trigger:package:fips` manual job within the `Trigger:ee-package` downstream pipeline must succeed.
+- [ ] If CI configuration is changed, the branch must be pushed to [`dev.gitlab.org`](https://dev.gitlab.org/gitlab/omnibus-gitlab) to confirm regular branch builds aren't broken.
 ### Expected (please provide an explanation if not completing)
-- [ ] Test plan indicating conditions for success has been posted and passes
-- [ ] Documentation created/updated
-- [ ] Tests added
-- [ ] Integration tests added to [GitLab QA](https://gitlab.com/gitlab-org/gitlab-qa)
-- [ ] Equivalent MR/issue for the [GitLab Chart](https://gitlab.com/gitlab-org/charts/gitlab) opened
+
+- [ ] Test plan indicating conditions for success has been posted and passes.
+- [ ] Documentation created/updated.
+- [ ] Tests added.
+- [ ] Integration tests added to [GitLab QA](https://gitlab.com/gitlab-org/gitlab-qa).
+- [ ] Equivalent MR/issue for the [GitLab Chart](https://gitlab.com/gitlab-org/charts/gitlab) opened.
 - [ ] Validate potential values for new configuration settings. Formats such as integer `10`, duration `10s`, URI `scheme://user:passwd@host:port` may require quotation or other special handling when rendered in a template and written to a configuration file.