Improve promote-to-primary-node command by

- removing unused option confirm-removing-keys,
- improving description for skip-preflight-checks

changelogs/unreleased/ag-fix-description-of-option.yml

+---
+title: 'Geo: Remove confirm-removing-keys option from promote-to-primary-node command'
+merge_request: 4403
+author:
+type: changed

files/gitlab-ctl-commands-ee/promote_to_primary_node.rb

@@ -30,11 +30,7 @@ def get_ctl_options
       options[:confirm_primary_is_down] = p
     end
-    opts.on('-c', '--[no-]confirm-removing-keys', 'Do not ask for confirmation about removing keys') do |c|
-      options[:confirm_removing_keys] = c
-    end
-
-    opts.on('-m', '--skip-preflight-checks', 'Do not ask for confirmation if manual checks ran') do |m|
+    opts.on('-m', '--skip-preflight-checks', 'Perform promotion without running any preflight checks') do |m|
       options[:skip_preflight_checks] = m
     end
   end.parse!(ARGV.dup)

spec/gitlab-ctl-commands-ee/promote_to_primary_node_spec.rb

@@ -16,10 +16,6 @@ describe 'gitlab-ctl promote-to-primary-node' do
                   '--confirm-primary-is-down',
                   { confirm_primary_is_down: true }
-  it_behaves_like 'geo promotion command accepts option',
-                  '--confirm-removing-keys',
-                  { confirm_removing_keys: true }
-
   it_behaves_like 'geo promotion command accepts option',
                   '--skip-preflight-checks',
                   { skip_preflight_checks: true }