Merge branch 'backport-fix-suggested-reviewers-15-10' into '15-10-stable'

[15.10 Backport] Fix suggested_reviewers runs when rails is disabled

See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6794



Merged-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Approved-by: Mitchell Nielsen <mnielsen@gitlab.com>
Approved-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Co-authored-by: Clemens Beck <cbeck@gitlab.com>

files/gitlab-cookbooks/gitlab-ee/recipes/default.rb

@@ -44,9 +44,11 @@ end
   end
 end
+rails_enable = node['gitlab']['gitlab-rails']['enable']
+
 # Geo secondary
 if node['gitlab']['geo-secondary']['enable']
-  if node['gitlab']['gitlab-rails']['enable']
+  if rails_enable
     include_recipe 'gitlab-ee::geo-secondary'
     include_recipe 'gitlab-ee::geo_database_migrations'
   end
@@ -55,7 +57,7 @@ else
 end
 # Suggested Reviewers
-include_recipe 'gitlab-ee::suggested_reviewers'
+include_recipe 'gitlab-ee::suggested_reviewers' if rails_enable
 # Create the pgbouncer users
 include_recipe 'pgbouncer::user'

spec/chef/cookbooks/gitlab-ee/recipes/suggested_reviewers_spec.rb

@@ -65,4 +65,28 @@ RSpec.describe 'gitlab-ee::suggested_reviwers' do
       it_behaves_like 'Create suggested reviewer secrets and notifies services'
     end
   end
+
+  context 'rails configuration' do
+    before do
+      stub_gitlab_rb(
+        gitlab_rails: {
+          enable: rails_enabled,
+        }
+      )
+    end
+
+    context 'is enabled' do
+      let(:rails_enabled) { true }
+      it 'does incudes suggested reviewers' do
+        expect(chef_run).to include_recipe('gitlab-ee::suggested_reviewers')
+      end
+    end
+
+    context 'is disabled' do
+      let(:rails_enabled) { false }
+      it 'does not incudes suggested reviewers' do
+        expect(chef_run).to_not include_recipe('gitlab-ee::suggested_reviewers')
+      end
+    end
+  end
 end