- Fix the behavior to match what we want, it had been allowing a NIL
  sockets directory to get passed to the File method

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Bring joy to Rubocop

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>

- Remove the workhorse helper methods that are refactored out
- Fix workhorse helper tests

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

As discussed in
https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/4324, we
can set the default attribute for `gitlab_workhorse['auth_socket']` to
`nil` as the empty string value so we can use
`node['gitlab']['gitlab-workhorse']['auth_socket']` in the template
instead of `Gitlab['gitlab_workhorse']['auth_socket']`.

In Workhorse, it's not absolutely necessary to have both -authSocket and
-authBackend arguments, as long as least one is available to all GitLab
application hosts. In a single-node Ominbus install, -authSocket will
suffice, but in multi-node installations -authBackend may only be
needed.

To support the second case and make it possible to disable listening to
a UNIX socket, admins can do the following:

```
gitlab_workhorse['auth_socket'] = nil
gitlab_workhorse['auth_backend'] = 'https://workhorse.example.com'
```

Repo
https://github.com/opscode/omnibus-chef-server.git
Revision
8fc56f1e0c20cd8109d85d512b1d81066951ad8a

Repo
https://github.com/opscode/omnibus-chef-server.git
Path
files/chef-server-cookbooks/chef-server/recipes/postgresql_disable.rb
Revision
6a11fd840045a7ae7961e5a37439371b7407f3e9

Repo
https://github.com/opscode/omnibus-chef-server.git
Path
config/software/chef-server-cookbooks.rb
Revision
6a11fd840045a7ae7961e5a37439371b7407f3e9

Source repo:
https://github.com/opscode/omnibus-chef-server
Source file:
config/software/chef-server-webui.rb
Revision:
6a11fd840045a7ae7961e5a37439371b7407f3e9