- fix gitaly spec to match logic

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Purge the workhorse helper methods that had been refactored out from
  other files and clean up the affected spec tests to pass

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Rubocop was sad, this fix makes it happy

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Do not automatically use sockets directory, allow a user to set the
  directory

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Merge conflict resolution during the rebase touched a few places that
  needed updates to use the Workhorse Helper.
- Updated gitaly rspec to match the new expectations

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

This will not only help improve observability of API calls made by
Gitaly, but it will also enable Gitaly to download LFS files via the API
to support archive downloads
(https://gitlab.com/gitlab-org/gitlab/-/issues/15079).

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5666

Ian Baum authored 4 years ago and Balasankar C committed 4 years ago

* Matching behavior in rails codebase
* This will be default behavior in 4.0

Ian Baum authored 4 years ago and DJ Mountney committed 4 years ago

* Incoroporates our changes to the coobkook so we get our desired
  behavior
* Use start_down instead of down
* Stop checking for permissions on log directories. The runit cookbook does not explicitly create this.
* Rename runit control templates. Don't use -control in the name anymore, upstream has removed that
* In the v5 version of the runit cookbook, they are colliding with the chef service properties

By default, Rugged searches inside `/etc/gitconfig` instead of
`/opt/gitlab/embedded/etc/gitconfig` for system-wide options unless the
`Rugged::Settings['search_path_system']` is set.

This means that important options such as `core.fsyncObjectFiles` are
not propagated to gitaly-ruby, which can result in data loss after
servers are rebooted. We worked around this problem by propagating the
`core` options in the user's `.gitconfig` file in
https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/3648, but we
shouldn't need to do this.

The command-line `git` doesn't have this issue because it uses the
`prefix` compile-time option, but this isn't available in Rugged.

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>

- Release 12.0 will default to JSON logging for all services that
  support it except for the registry. This includes gitaly,
  gitlab-shell, gitlab-workhorse, sidekiq, gitlab-pages.

Resolves: https://gitlab.com/gitlab-org/omnibus-gitlab/issues/4102



Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Takuya Noguchi authored 5 years ago and Ian Baum committed 5 years ago

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>

1. Step into runit_service resource
2. Check for reload_log_dir block to be notified
3. Pass options as needed by runit_service

Move env directory of all services to /opt/gitlab/etc/<service>/env

Add tests for the various services altered with #3701.
This ensures that the etc/env/* items are populated & contain
correct content.

The missing PYTHONPATH means the gitaly-ruby process can't render
non-Markdown Wiki pages.

Closes #3678