Merge branch '5672-consolidated-form-for-object-storage-does-not-work-in-docker-install-of-gitlab' into 'master'

Resolve "Consolidated form for object storage does not work in docker install of GitLab"

Closes #5672

See merge request gitlab-org/omnibus-gitlab!4656

Add selinux module for gitlab-shell

Closes #5694

See merge request gitlab-org/omnibus-gitlab!4598

Allow bootstrapping patroni Standby Cluster

Closes #5633

See merge request gitlab-org/omnibus-gitlab!4558

Don't disable crond, only relevant cronjob

See merge request gitlab-org/omnibus-gitlab!4651

This is, because other recipes might also depend on the presence of the
service.

Explicitly set group for repositories_storages and improve manage-storage-directories tests

See merge request gitlab-org/omnibus-gitlab!4589

Remove EE only note for packages in gitlab.yml.erb

See merge request gitlab-org/omnibus-gitlab!4594

Add coverage for existing features and changes related to the standby cluster

We are not relying on `sql_replication_password` as we need it in cleartext here.

Add support for PostgreSQL certificate authentication

See merge request gitlab-org/omnibus-gitlab!4618

Ian Baum authored 4 years ago and Balasankar C committed 4 years ago

* Adds postgresql['cert_auth_addresses'] attribute
* Updates pg_hba.conf template to add entries in that attribute

- Had removed sockets_directory method from most places, but needed to
  remove it from the helper and that exposed it being used in one other
  location

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Restart workhorse if the socket directory changes. In its own commit
  so it can be reverted by the maintainer if not approved

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Take "get_ctl_options" methods out of global namespace

See merge request gitlab-org/omnibus-gitlab!4646

- Add test to be sure selinux helper sets context when the user
  configures their own workhorse directory
- refactored selinux helper to not use the deprecated helper methods as
  discovered when the new test failed

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Reduce complexity in workhorse helper rspec tests to reflet the
  refactor we have made

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- fix gitaly spec to match logic

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Due to change load order these methods got conflicted

- Define the outlined expected behavior from parse_variable with an
  rspec that outlines the three cases we outlined for unix sockets and
  checks to be sure that we get back the TCP socket if set

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Fix the behavior to match what we want, it had been allowing a NIL
  sockets directory to get passed to the File method

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Bring joy to Rubocop

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>

[ci skip]

Add pages object storage settings

See merge request gitlab-org/omnibus-gitlab!4623

Update docs to specify recommended size for /dev/shm directory in Docker containers

Closes #5476

See merge request gitlab-org/omnibus-gitlab!4532

Part of https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5577

Merge branch '3970-docker-assets-download-package-should-fail-when-package-is-not-found' into 'master'

Resolve "docker/assets/download-package should fail when package is not found"

Closes #3970

See merge request gitlab-org/omnibus-gitlab!4641

Ian Baum authored 4 years ago and Balasankar C committed 4 years ago

* Currently we silently ignore the error, which can be difficult to
  debug as it only bubbles up later in the image build process

Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>

Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>