- Restart workhorse if the socket directory changes. In its own commit
  so it can be reverted by the maintainer if not approved

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Add test to be sure selinux helper sets context when the user
  configures their own workhorse directory
- refactored selinux helper to not use the deprecated helper methods as
  discovered when the new test failed

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Reduce complexity in workhorse helper rspec tests to reflet the
  refactor we have made

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- fix gitaly spec to match logic

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Define the outlined expected behavior from parse_variable with an
  rspec that outlines the three cases we outlined for unix sockets and
  checks to be sure that we get back the TCP socket if set

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Fix the behavior to match what we want, it had been allowing a NIL
  sockets directory to get passed to the File method

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Bring joy to Rubocop

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>

Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>

- Purge the workhorse helper methods that had been refactored out from
  other files and clean up the affected spec tests to pass

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Remove the workhorse helper methods that are refactored out
- Fix workhorse helper tests

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Per review discussin, change the workhorse listen_addr default to nil

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Rubocop was sad, this fix makes it happy

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Do not automatically use sockets directory, allow a user to set the
  directory

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Run SELinux helper after helper files associated with GitLab Workhorse
  are created and able to receive file context restoration commands
- Move GitLab Workhorse UNIX sockets into a directory allowing them to
  inherit the correct SELinux file context after a service restart
- Adds GitLab Workhorse Helper class to ensure new UNIX sockets always
  inherit the proper SELinux file context
- Add rspect tests for new GitLab Workhorse helper
- Add clause to remove orphan GitLab Workhorse sockets if they exist
- Add rspec test to ensure orphan socket cleanup happens when necessary

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5694



Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Adds a suite of rspec tests for the gitlab workhorse helper
- Checks for and removes orphan workhorse socket files if present

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Changes the socket_file_path to be the listen_address method in the
  Workhorse helper per review discussion

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Fixes a rubocop warning that popped up after merge conflit.

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Merge conflict resolution during the rebase touched a few places that
  needed updates to use the Workhorse Helper.
- Updated gitaly rspec to match the new expectations

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

- Run the SELinux helper after GitLab Workhorse and other files are
  created ensuring their file contexts are restored
- Place GitLab Workhorse socket files into a sockets directory allowing
  the SELinux file context to be inherited on service restarts
- Add a GitLab Workhorse helper to ensure that new UNIX sockets for
  Workhorse always inherit the proper SELinux file context

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Resolve "Migrations can silently fail during deployments"

Closes #5610

See merge request gitlab-org/omnibus-gitlab!4591

Ian Baum authored 4 years ago and DJ Mountney committed 4 years ago

* Due to a change in behavior of the Omnibus::Ctl.reconfigure function,
we no longer exited non-zero if reconfigure failed during a package
upgrade. This will return the behavior of exiting with the
corresponding exit code at the time of the error

Docs: Point `Failed to connect to the internal GitLab API`error to separate Pages troubleshooting

See merge request gitlab-org/omnibus-gitlab!4624

Reorganize default attributes

See merge request gitlab-org/omnibus-gitlab!4569

Update required permissions and ownership docs

See merge request gitlab-org/omnibus-gitlab!4614

List all accounts with uid/gid option

See merge request gitlab-org/omnibus-gitlab!4615

Add database reindexing cronjob

See merge request gitlab-org/omnibus-gitlab!4602

Andreas Brandl authored 4 years ago and Ian Baum committed 4 years ago

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/249662