PostgresQL start/stop not working as expected

I was testing !14 (merged) and I am seeing strange behaviour when running gitlab-ctl reconfigure a second time.

After the first reconfigure run / reboot:

$ pstree
init─┬─atd
     ├─cron
     ├─dbus-daemon
     ├─dhclient3
     ├─6*[getty]
     ├─irqbalance
     ├─ntpdate─┬─lockfile-touch
     │         └─ntpdate
     ├─ondemand───sleep
     ├─rsyslogd───3*[{rsyslogd}]
     ├─runsvdir─┬─runsv─┬─redis-server───2*[{redis-server}]
     │          │       └─svlogd
     │          └─runsv─┬─postgres───5*[postgres]
     │                  └─svlogd
     ├─sshd───sshd───sshd───bash───pstree
     ├─udevd───2*[udevd]
     ├─upstart-socket-
     ├─upstart-udev-br
     ├─vmtoolsd
     └─vmware-vmblock-───2*[{vmware-vmblock-}]

Run gitlab-ctl reconfigure once. Then all of a sudden, redis and postgresql are no longer children of runsvdir:

$ pstree
init─┬─atd
     ├─cron
     ├─dbus-daemon
     ├─dhclient3
     ├─6*[getty]
     ├─ondemand───sleep
     ├─postgres───5*[postgres]
     ├─redis-server───2*[{redis-server}]
     ├─rsyslogd───3*[{rsyslogd}]
     ├─runsvdir───2*[runsv───svlogd]
     ├─sshd───sshd───sshd───bash───pstree
     ├─2*[svlogd]
     ├─udevd───2*[udevd]
     ├─upstart-socket-
     ├─upstart-udev-br
     ├─vmtoolsd
     └─vmware-vmblock-───2*[{vmware-vmblock-}]

Reconfigure again.

Now I can no longer stop postgres.

$ sudo gitlab-ctl stop postgresql
ok: down: postgresql: 0s, normally up, want up
$ pstree
init─┬─atd
     ├─cron
     ├─dbus-daemon
     ├─dhclient3
     ├─6*[getty]
     ├─postgres───5*[postgres]
     ├─redis-server───2*[{redis-server}]
     ├─rsyslogd───3*[{rsyslogd}]
     ├─runsvdir─┬─runsv───svlogd
     │          └─runsv
     ├─sshd───sshd───sshd───bash───pstree
     ├─2*[svlogd]
     ├─udevd───2*[udevd]
     ├─upstart-socket-
     ├─upstart-udev-br
     ├─vmtoolsd
     └─vmware-vmblock-───2*[{vmware-vmblock-}]

mentioned in merge request !16 (merged)

Fixed by and explained in 1084c047

Status changed to closed