License generation issues

There are some issues with the generated /opt/gitlab/LICENSES file being uncovered in gitlab-pivotal/p-gitlab-ee#41 (closed)

This should be a good place to track them

config/software/chef-gem.rb references blob in the github url, should use the raw version

config/software/config_guess.rb lists config.guess, and config.sub as the license file, neither of them actually is a license file.

config/software/ncurses.rb references html files for license_file

config/software/omnibus-ctl.rb references blob in the github url, it should use the raw version

created branch 2568-license-generation-issues

mentioned in merge request !1731 (merged)

assigned to @ibaum

So, for config_guess, the license is in the headers of the two files. The end result being we have license, plus bash scripts generated in /opt/gitlab/LICENSE.

The links in ncurses are actually a link to the history of the ncurses license. Which is kind of like MIT-X11 but not MIT-X11.

The license itself is include in the README file

removed assignee

added Internal label

@balasankarc Can you make sure that these are addressed since you worked last on the license features?

changed milestone to %9.4

@ibaum Thanks for noting down the problems!

[From mobile. Please ignore spelling mistakes]

@ibaum Thanks.

@marin chef-gem is easy enough to fix. Regarding config_guess and ncurses, we are imitating what omnibus-software does. The optimal solution is the upstream providing specific LICENSE files. But what we can easily do is provide those files as patches (and explicitly mention on the top of those files "This license information is extracted from the following files: " in big block letters).

closed via merge request !1731 (merged)

mentioned in commit b270468e

mentioned in commit 522c31b3

mentioned in commit c2bd5ff6

mentioned in commit dd7d6083

mentioned in merge request !1869 (merged)