SLES EE build failing to make docker-distribution (registry)

In the latest master builds, the SLES package failed to build. This appears to be related to the included Go/GOLANG version. Get this in sync with the rest of the docker builds to fix. Blocking master.

The following shell command exited with status 2:
    $ DOCKER_BUILDTAGS=include_gcs GO15VENDOREXPERIMENT=1 GOPATH=/var/cache/omnibus/src/registry MAKE=gmake PREFIX=/opt/gitlab/embedded gmake build

Output:
    gmake[1]: Entering directory '/var/cache/omnibus/src/registry/src/github.com/docker/distribution'
+ build
Makefile:71: recipe for target 'build' failed
gmake[1]: Leaving directory '/var/cache/omnibus/src/registry/src/github.com/docker/distribution'
...
# github.com/docker/distribution/registry/api/errcode
registry/api/errcode/register.go:74: undefined: http.StatusTooManyRequests
...
# github.com/docker/distribution/testutil
testutil/tarfile.go:48: undefined: "math/rand".Read
...
# github.com/docker/distribution/registry/storage/driver/testsuites
registry/storage/driver/testsuites/testsuites.go:1218: undefined: "math/rand".Read

Pointers to Go version:

• undefined: http.StateTooManyRequests:
  • seen in consul
  • seen in buford
• Both errors, in our own tracker: https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2398

cc @marin

For reference, I've created https://gitlab.com/gitlab-org/gitlab-omnibus-builder/merge_requests/53 and merged it but the build failed with another issue now.

@marin refers to https://dev.gitlab.org/cookbooks/gitlab-omnibus-builder/-/jobs/1235307

Step 10/27 : RUN localedef -i en_US -f UTF-8 en_US.UTF-8
 ---> Running in 5778f91e1da9
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
character map file `UTF-8' not found: No such file or directory
cannot read character map directory `/usr/share/i18n/charmaps': No such file or directory
The command '/bin/sh -c localedef -i en_US -f UTF-8 en_US.UTF-8' returned a non-zero code: 1

Interestingly enough, if I build the container, docker run -it HASH /bin/bash -l and then /bin/sh -c 'localedef -i en_US -f UTF-8 en_US.UTF-8' .. there is no issue.

41c46f68d93d:/usr/share/locale # /bin/sh -c 'localedef -i en_US -f UTF-8 en_US.UTF-8'
41c46f68d93d:/usr/share/locale # echo $?
0

And not if I repeat the processes including the ENV exports.

41c46f68d93d:/usr/share/locale # export LANG=en_US.UTF-8
41c46f68d93d:/usr/share/locale # export LC_ALL=en_US.UTF-8
41c46f68d93d:/usr/share/locale # export LANGUAGE=en_US:en
41c46f68d93d:/usr/share/locale #  localedef -i en_US -f UTF-8 en_US.UTF-8
41c46f68d93d:/usr/share/locale # echo $?
0

Successful container build on dev LANG

Fixing nodejs (https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2569) seems to have effectively also addressed the problem here.

mentioned in issue #2569 (closed)

Closing this, now that #2569 (closed) closed, since the below are merged.

https://gitlab.com/gitlab-org/gitlab-omnibus-builder/merge_requests/53 https://gitlab.com/gitlab-org/gitlab-omnibus-builder/merge_requests/54

closed