Backport Signing to supported Stable trees

Stemming from #2537 (closed)

We need to backport necessary changes to 9-3-stable and 9-4-stable branches, by updating the versions of Omnibus used in those branches. These will require MRs to https://gitlab.com/gitlab-org/omnibus, possibly by creating branches for use by the omnibus-gitlab stable trees.

According to the Gemfile.lock on the branches (reference: https://gitlab.com/gitlab-org/omnibus/commits/gitlab-omnibus-ad5d3f98)

• 9-3-stable is on the same branch of ominbus as master, however it is from 01 June 2017 (, making it prior to the dependency and license output changes by @balasankarc. While I don't immediately see any inconsistencies, I'd like @balasankarc & @marin to chime in with any expected implications against omnibus-gitlab for these changes.
• 9-4-stable is on the same branch of omnibus as master, however it is from 05 July 2017 (e5390963), which is right before my changes for signing were merged. Thus, 9.4.x is simple.

If there are no ill effects, we can simply cherry-pick into stable for the changes to the Gemfile.lock, but will need to review the state of the .gitlab-ci.yml on each branch.

9-3-stable : https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1787 There were some minor conflicts, but easily resolved.

9-4-stable : https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1788 Directly cherry-picked.

mentioned in issue #2537 (closed)

@WarheadsSE The changes in https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1679 should also be cherry picked as it is basically the counterpart of the license organization stuff I did in omnibus. I assume the license check will fail otherwise.

In attempting to cherry-pick 75d3b9e98b6ebd46b7dda6898c8c894c76675ce6

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

        both modified:   Gemfile.lock
        deleted by us:   lib/gitlab/license_analyzer.rb

I find the above interesting, and don't want to just trample on that. The Gemfile.lock can be ignored, as we're updating that, but that license_analyzer.rb doesn't exist is sticking point.

This appears that the file is indeed entirely missing within the 9-3-stable tree, so the whole of that configuration would need to be backported.

I reached back and grabbed ab01aa1a to resolve the above issue.

9-4-stable already has all of these changes in place.

I will need to re-touch these once the documentation changes et all are in place.

We've altered the name of the bucket/key, as well.

I've updated both branches with the changes to the key & bucket. Documentation to follow.

marked this issue as related to #2537 (closed)

Now that they have been merged to the current stable trees, closing.

closed