Reconfigure always changes postgres runit files

I've noticed that everytime reconfigure runs, we get a change:

 file[/opt/gitlab/sv/postgresql/supervise/ok] action touch
    - create new file /opt/gitlab/sv/postgresql/supervise/ok
    - change owner from '' to 'gitlab-psql'
    - change group from '' to 'gitlab-psql'
    - update utime on file /opt/gitlab/sv/postgresql/supervise/ok
  * file[/opt/gitlab/sv/postgresql/log/supervise/ok] action touch
    - create new file /opt/gitlab/sv/postgresql/log/supervise/ok
    - change owner from '' to 'gitlab-psql'
    - change group from '' to 'gitlab-psql'
    - update utime on file /opt/gitlab/sv/postgresql/log/supervise/ok
  * file[/opt/gitlab/sv/postgresql/supervise/control] action touch
    - create new file /opt/gitlab/sv/postgresql/supervise/control
    - change owner from '' to 'gitlab-psql'
    - change group from '' to 'gitlab-psql'
    - update utime on file /opt/gitlab/sv/postgresql/supervise/control
  * file[/opt/gitlab/sv/postgresql/log/supervise/control] action touch
    - create new file /opt/gitlab/sv/postgresql/log/supervise/control
    - change owner from '' to 'gitlab-psql'
    - change group from '' to 'gitlab-psql'
    - update utime on file /opt/gitlab/sv/postgresql/log/supervise/control
  * service[postgresql] action nothing (skipped due to action :nothing)

@ibaum We discussed this recently and I was under the impression that this was resolved. Can we update these resources from touch to create or create_if_missing?

/cc @gitlab-build-team

changed milestone to %9.5

We should fix this before the release.

I thought it was resolved too. Should be a straightforward fix, I will add it to my TODO list for tomorrow.

assigned to @ibaum

created branch 2659-reconfigure-always-changes-postgres-runit-files

mentioned in merge request !1841 (merged)

The reason we originally went with touch is that these are actually pipes. The documented process for allowing a user to control a service is to change the ownership of these after runit creates them.

So we can't create or create_if_missing on these, as these actions can't handle pipes. I'll see about adding a guard based on if the permissions don't match.

closed via merge request !1841 (merged)

mentioned in commit 8acd0fae

mentioned in commit bbbe2037

mentioned in commit 466f1614