Gitaly Server version is not being upgraded on dev.gitlab.org even though GITALY_SERVER_VERSION is changing

As part of the nightly build, Gitaly is being restarted and replaced with a newer build, but the actual version seems to be stuck on 0.25.0. This version hit GitLab-CE master on 27 July but we've update it multiple times since then: https://gitlab.com/gitlab-org/gitlab-ce/commits/master/GITALY_SERVER_VERSION

At first, I thought this was an issue with the Gitaly service not being restarted, but the gitlab_build_info metric in Prometheus (https://prometheus.gitlab.com/graph?g0.range_input=3w&g0.expr=gitlab_build_info%7Bjob%3D%22gitaly-dev%22%2C+version%3D%220.25.0%22%7D&g0.tab=0) shows that the service is being restarted, with a new build of the old Gitaly version.

changed title from Gitaly Server version is not being upgraded on {-dev.gitlab.org even though GITALY_SERVER_VERSION is-} to Gitaly Server version is not being upgraded on dev.gitlab.org even though GITALY_SERVER_VERSION is changing

@andrewn Because we had locked it by https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1805 while we were waiting for https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1798. Now that is in, we should revert it.

/cc @gitlab-build-team

What @balasankarc said :)

I've reverted the change in master with 4799c889

thanks for the super-fast response! Build team rocks!

mentioned in issue gitaly#465 (closed)

Hence, closing.

closed

FYI, GitLab 9.5 RC2 has the same issue. Do we need to roll RC3 with this before doing a production deploy?

This was also reverted in stable so RC3 will contain the newer version. However, at this moment gitaly does not compile.

https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2680