Geo: Proper services are not enabled by default in 10.0

Zendesk: https://gitlab.zendesk.com/agent/tickets/82943

When a Geo role (primary or secondary) are set in /etc/gitlab/gitlab.rb, it seems like all necessary default services are not set to enable properly. Things like Unicorn, Workhorse, Nginx, Redis and PostgreSQL do not have service definitions and don't start up unless explicitly set in /etc/gitlab/gitlab.rb through the respective service['enable'] = true setting.

cc/ @twk3 @marin

@twk3 Our GeoSecondaryRole is not enabling any services because of Geo group role. We should fix this in patch release.

added Unscheduled label

changed milestone to %10.0

Note this happened on both primary and secondaries.

This applies to both roles, correct @dblessing.

Previously we treated the geo roles differently than the rest, so that they didn't impact the enablement of the gitlab-rails services.

Need to bring back that sort of logic, so that the default role still loads.

@twk3 Sounds like you're saying this was sort of expected. What is the missing piece that the customer would need to add to make this work, then? I'm OK if that's the resolution since this is a 9.x to 10.0 breaking change - just so we know what the solution is.

@dblessing no, I missed/forgot while refactoring the roles. It was not intended to require you to manually enable everything.

We've been running nightly builds for Geo. Any ideas how we didn't get bit by this?

/cc: @nick.thomas, @jarv

mentioned in merge request !1963 (merged)

closed via commit 11e6dbfd

closed via merge request !1963 (merged)

mentioned in commit 340e18cd

mentioned in commit b179300c

@jarv can you link to the recipes we use to manage the prod.geo and sync.geo ? I've not actually seen them yet!

We've been running nightly builds for Geo. Any ideas how we didn't get bit by this?

I do remember seeing this actually as I was switching the testbed from manually provisioned to being chef managed. I manually set everything explicitly to be enabled in gitlab.rb as that is what we do when using the omnibus cookbook. Unfortunately there were so many changes happening at that time it got overlooked.

@nick.thomas It uses the the base cookbooks for all gitlab hosts, specifically the ones in gitlab-server, gitlab-openssh and gitlab-openssh::authorized_keys for setting up db lookups for authorized keys.

There is not a specific cookbook for geo as since this testbed was provisioned awhile ago gitlab.rb is not managed at all by chef.

mentioned in commit 11e6dbfd