The GitLab backup script assumes it can rename public/uploads
The GitLab backup script assumes it can rename /opt/gitlab/embedded/service/gitlab-rails/public/uploads. This assumption does not hold because public/uploads is a symlink to /var/opt/gitlab/uploads.
I propose to fix this as follows for the time being:
- patch the backup script to follow symlinks and find the real path;
- move uploads from
/var/opt/gitlab/uploads(where the backup script cannot rename it) to/var/opt/gitlab/gitlab-rails/uploads(where it can be renamed).
In the longer term, we should make the uploads path configurable upstream in gitlab-rails. (gitlab core team https://dev.gitlab.org/gitlab/gitlabhq/issues/988)
/cc @sytses
Activity
@jacobvosmaer Didn't you create an issue to fix the backup script in master?
@sytses that is for a separate issue (retrieving the gitlab-rails git revision from Rails.root).
What is needed for this issue on the gitlab-rails side is to make the backups of user uploads compatible with
public/uploadsbeing a symlink. If we can make the uploads path configurable in gitlab-rails (in the future), symlink support is not needed.mentioned in merge request !56 (merged)
