gitlab-ctl tail: cannot follow ‘-’ by name

If /var/log/gitlab is a symlink like

root@gitlab:/var/log# ls -l | grep gitlab
lrwxrwxrwx 1 root   root      29 2015-08-16 13:41 gitlab -> /gitlab-persistent/log/gitlab/

then gitlab-ctl tail always fails with

root@gitlab:/var/log# gitlab-ctl tail
tail: cannot follow ‘-’ by name

The same thing happens if gitlab/ is a non-symlink directory containing symlinks.

Not a fun thing to have happen during a first-time gitlab setup, when you don't even know which logs you're supposed to be looking at.

Sounds like a bug in https://github.com/chef/omnibus-ctl

code is in https://github.com/chef/omnibus-ctl/blob/b0e4c32f51dadb0131ece3edb60261f7ce5482b3/lib/omnibus-ctl.rb#L427

probably the 'find' command is missing a '-L'.

I am not sure what is the best way to move the log directory, but a symlink at /var/log/gitlab apparently is not it at the moment.

Added Enhancement label

Added Upstream label

I suggested the fix @jacobvosmaer suggested and they were happy with it: https://github.com/chef/omnibus-ctl/pull/49. Don't know if this is still an issue for us.

We'll need to ensure that this has been updated within Omnibus GitLab to match the updated version.

assigned to @balasankarc

removed assignee

added For Scheduling up-for-grabs labels

removed Upstream label

Anyone can pick this up :)

@marin Do we patch or do we bump? Or do we first test if latest version breaks anything and if it does, then patch? (Ok, I think I've covered all the options)

@balasankarc We try to bump to the latest version and see what else is needed.

added customer label

ZD: https://gitlab.zendesk.com/agent/tickets/77798

added Scheduled and removed For Scheduling labels

changed milestone to %9.4

mentioned in merge request !1643 (merged)

closed via merge request !1643 (merged)

mentioned in commit 47729eca