Bump omnibus-ctl version to 0.5.0

Closes #726 (closed)

@gitlab-build-team I have left some comments as discussion points. I am now doubtful if it is worth to make all these changes and bump or just maintain a patch. A review would be great (in other words, can I know your opinions about the changes and whether you think whatever I understand from omnibus-ctl's code is correct or not? - especially the Kernel.exit part)

@balasankarc some minor wording changes, then you can assign to @marin for final review

@twk3 Thanks.

@marin Assigning for review.

assigned to @marin

added 77 commits

• 600988b0...f12da86c - 68 commits from branch master
• 15489d5d - Bump omnibus-ctl version to 0.5.0
• d9ffff6f - Create toggle file to override license check
• 1e11fb3f - Add step to accept license in postinst
• 88e02561 - Update option parsing
• 0cf2893c - Revert "Update option parsing"
• ed2fad39 - Rename parse_options to a gitlab specific one to avoid collission
• 8b28d204 - Change exit! to Kernel.exit
• c72beb76 - Add comments and make notification more verbose
• 5bd8cd00 - Improve notification message

Compare with previous version

resolved all discussions

@marin Made the changes you mentioned. I also rebased and cleaned up the commit history a bit (I didn't want to squash as there was a commit message in https://gitlab.com/gitlab-org/omnibus-gitlab/commit/4ee6e8716df91edbf24e6045030726168e57a39f about the change we made)

resolved all discussions

mentioned in issue #2363 (closed)

We will wait with this change until we get the go-ahead from legal. In the mean time, we will fork omnibus-ctl and patch the change that we require. After legal clears on what action we can take, we will go back to this.

added blocked label

added 32 commits

• 4ee6e871...0df61ab6 - 26 commits from branch master
• 0cda9350 - Bump omnibus-ctl version to 0.5.0
• df138135 - Add step to accept license in postinst
• d6eae89d - Rename parse_options to a gitlab specific one to avoid collission
• 192fa256 - Change exit! to Kernel.exit
• 7294c9bc - Revert "Add step to accept license in postinst"
• 3369e933 - Add patch for omnibus-ctl to skip license acceptance

Compare with previous version

@marin I've added a patch for omnibus-ctl that removes the license acceptance check from reconfigure. Hence, unblocking.

removed blocked label

resolved all discussions

approved this merge request

changed milestone to %9.4

added 34 commits

• 3369e933...499d856f - 27 commits from branch master
• 8efbbbd0 - Bump omnibus-ctl version to 0.5.0
• efe5e9e7 - Add step to accept license in postinst
• 784ee98a - Rename parse_options to a gitlab specific one to avoid collission
• b26160c7 - Change exit! to Kernel.exit
• 4b3c4136 - Revert "Add step to accept license in postinst"
• 2ba5ef1a - Add patch for omnibus-ctl to skip license acceptance
• 888199f6 - Add a changelog item for omnibus-ctl.

Compare with previous version

approved this merge request

mentioned in commit 47729eca

merged