Add prometheus to update-permissions

I was restoring a dockerized gitlab instance from a backup and noticed errors even after calling update-permissions.

Turned out that the script was missing prometheus stuff, this is now fixed.

I also moved log-related chown commands into if id -u gitlab-XXX; then as it makes more sense.

These errors were showing up in a loop before I manually changed permissions:

level=info msg="Starting prometheus (version=, branch=, revision=)" source="main.go:88" 
level=info msg="Build context (go=go1.8.1, user=, date=)" source="main.go:89" 
level=info msg="Loading configuration file /var/opt/gitlab/prometheus/prometheus.yml" source="main.go:251" 
level=error msg="Could not lock /var/opt/gitlab/prometheus/data/DIRTY, Prometheus already running?" source="persistence.go:200"
level=error msg="Error opening memory series storage: open /var/opt/gitlab/prometheus/data/DIRTY: permission denied" source="main.go:191" 

mentioned in issue #2553

mentioned in issue #2556 (closed)

@kachkaev Just wanted to chime in here :)

I was fixing https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2074 and noted that perhaps we should do a full review in the near future, if time allows. Your MR here points out that we indeed need to do a deeper review, which I will be making an issue for soon, and doing a complete review of all Omnibus GitLab packaged/managed services inside the container.

Soon, we will merge https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1688, at which point I would ask that you rebase your changes based on that MR, which also moves the logs as you did, but also alters the chown calls to handle the even where a directory doesn't exist, such as when the registry has not yet been used/enabled, or you're on CE but checking a directory belonging to an EE feature.

cc @marin

@kachkaev Thanks for your contribution! !1688 (merged) is merged, can you rebase your MR on top of current master?

added 29 commits

• 5c66049d...b0fc1c85 - 28 commits from branch gitlab-org:master
• 31eb5c1b - Add prometheus to update-permissions

Compare with previous version

Must be done now @marin. Although I'm not sure I've done things correctly, please let me know if so!

Looks good @kachkaev

assigned to @marin

changed milestone to %9.4

approved this merge request

merged

mentioned in commit b8a73b04

mentioned in issue #2518 (closed)