Build artifacts support
Fixes #874 (closed)
Merge request reports
Activity
504 504 ## see https://gitlab.com/gitlab-org/omnibus-gitlab/tree/629def0a7a26e7c2326566f0758d4a27857b52a3/doc/gitlab-ci/README.md 505 505 506 506 # ci_external_url 'http://ci.example.com' 507 # gitlab_ci['gitlab_ci_all_broken_builds'] = true - Last reply by Kamil Trzcińśki
I miss X-Accel-Redirect and X-Accel-Mapping in nginx config.
@ayufan And that is why this is still WIP, need to make sure that nginx-upload-module compiles first :) In any case, still working on it :)
Edited by Marin JankovskiAdded 1 commit:
- 93f2edca - Add X-Accel-Mapping.
- Last reply by Marin Jankovski
- Last reply by Kamil Trzcińśki
Added 1 commit:
- 75ea5de4 - Change root->alias.
Added 1 commit:
- adee113d - Let NGINX put uploads in artifacts/tmp-uploads dir.
@jacobvosmaer Can you do a sanity check cc @ayufan
- Last reply by Marin Jankovski
146 175 proxy_set_header X-Forwarded-Proto <%= @https ? "https" : "http" %>; 147 176 proxy_set_header X-Frame-Options SAMEORIGIN; 148 177 178 # Accelerate file downloading with Nginx 179 proxy_set_header X-Sendfile-Type "X-Accel-Redirect"; 180 proxy_set_header X-Accel-Mapping "<%= @artifacts_directory %>/=/artifacts/"; I don't know how to read this '=/artifacts/' business. @ayufan is this correct?
This is information for Rails app how can translate real path to nginx compatible location. The nginx when receves X-Accel-Redirect looks for location statements that matches, in this case it's /artifacts/. The /artifacts/ is not exposed to outside, because it's markes as internal, so it's used only by Nginx for X-Accel: https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/513/diffs#2def2844421452b29fe8913a4aea0e7f80633152_104_105
Added 1 commit:
- d8dd6cb3 - Make artifacts size configurable.
@jacobvosmaer @ayufan This is ready to merge, we might want to coordinate the next steps.
