New option for manual LFS storage area creation

This is a fix for #999 (closed). A new option gitlab_rails['manage_lfs_storage_path'] is available. Default is set to true to reproduce previous behaviour. When set to false, the dir specified to by gitlab_rails['lfs_storage_path'] is expected to be created, and writable by the user account running Gitlab.

@clement.moyroud Looks good. However, I had some time to process this and I think this might not be a best solution. The idea in general is good but we will have the same issue for any directory located in shared directory which would be on the NFS, this includes artifacts and LFS objects and anything else we will put in there. The general idea is to move all storage directories to shared, see this discussion.

This complicates what needs to be implemented. We probably want manage_shared_path option and a way to check whether we need to create the directories based off shared.

What do you think, any suggestions?

mentioned in merge request !678 (closed)

mentioned in merge request !689 (merged)

mentioned in commit 81a370d3

The change was merged with !689 (merged) and it should also cover your use case. Create an issue if you want to discuss this further.

Thanks for contributing though!

Status changed to closed

Thanks @marin, can't wait for 8.7 to be available 😃

@clement.moyroud Actually, I think we can include it for 8.6.

mentioned in commit 7d6e4bf7

mentioned in commit 1cea4457

I see you've merged with the 8.6 branch, thanks @marin!