Skip to content
Snippets Groups Projects
Stan Hu's avatar
commented on issue #120 "Protected branch on `master` causes direct pushes to master to fail on CE and EE" at GitLab.org / release-tools

Further, it doesn't appear that our own API allows you to set specific roles/groups/people on those protected branches anyway....

Robert Speicher's avatar
commented on issue #120 "Protected branch on `master` causes direct pushes to master to fail on CE and EE" at GitLab.org / release-tools

Looked into it quickly....

username-removed-128633's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

@rspeicher Thanks, addressed in 5618122!

username-removed-128633's avatar
pushed to branch rc/improve-remote-repository at GitLab.org / release-tools
  • 56181222 · Remove unused params and rename other params
username-removed-128633's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Weird, it works for me, but yeah --format='something' works too and is simpler, I'll change that.

username-removed-128633's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Yes, describe '.get' do doesn't output to stdout...

username-removed-128633's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Yes it's basically a stub.

username-removed-128633's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Actually, have_blob should now be called on a Rugged::Repository since I'm using Rugged::Repository#blob_at.

username-removed-128633's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Actually I changed .run_git to return [cmd_output, cmd_status] so we don't need this param anymore.

username-removed-128633's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

I think the call was ambiguous without that.

username-removed-128633's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

https://github.com/bbatsov/rubocop/blob/ce6483c8f83691837519ab0a4f996a74f9de11dc/lib/rubocop/cop/style/special_global_vars.rb

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

@rymai Couple more questions. 👍

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

paths might be more in line with the actual Git documentation/usage.

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

This argument doesn't work for me locally -- it can be either --format='something' or --pretty='something', and both seem to be functionally identi...

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Thes

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Any reason we shouldn't add this metadata to the top-level describe?

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

How do these actually silence the output? Is it basically a stub?

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

What's the benefit of using .for instead of expect(master.target)?

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Are we not using output until !86?

Robert Speicher's avatar
commented on merge request !177 "Add `head`, `status`, `log`, `fetch`, `checkout_new_branch`, `pull`, `push`, and `merge` to `RemoteRepository`" at GitLab.org / release-tools

Parentheses for the raise call are a bit unusual.