Skip to content
Snippets Groups Projects

Auto close popup after attaching merge request

Merged username-removed-408677 requested to merge auto-close-popup-after-attaching into master
All threads resolved!

After some further investigation, it looks like the callback needs to be the one to pass the t (trelloObject) to the callback in order for t.close() to work. I was previously passing in t from the parent context so that I could keep the parameter order with t as the first parameter.

https://gitlab.com/gitlab-org/trello-power-up/issues/27#note_33926763

Closes #27 (closed)

Edited by username-removed-408677

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-408677 changed the description

    changed the description

  • @ClemMakesApps there is an open discussion, not sure if you want to solve it or resolve it :grin:

  • After thinking more about this and what you said, I changed it to use a callbackWrapper so that we can preserve t as the first parameter.

  • username-removed-408677 resolved all discussions

    resolved all discussions

  • Filipa Lacerda approved this merge request

    approved this merge request

  • changed milestone to %1.0

  • Please register or sign in to reply
    Loading