Use view=simple for MR API
Closes #34 (closed)
Merge request reports
Activity
@stanhu is there any particular reason we did
view=simple
instead ofsimple=true
? It seems like we usesimple=true
for the Projects API. Just noticed that discrepancy today@ClemMakesApps This came from the review in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12766#note_34640370. The idea was that this allows for the possibility of different views if necessary.
Hmm, do we plan on changing the other APIs that use
simple=true
in the future @stanhu?assigned to @jschatz1
@smcgivern What do you think here? Should we just make our API consistent?
GraphQL is all views
I think the projects API should also accept a
view
param, and if we addedsimple
in 9.4, we should be safe to remove it. @rymai wdyt? My reasoning forview
is what if we add anextra_detail
view in future?view={simple,default,extra_detail}
-
simple=true
orextra_detail=true
, and the intersection of those isn't defined
@smcgivern Sounds good to me!
changed milestone to %1.0