Fix the interpreting of aws errors

docs/history.rst

@@ -3,11 +3,15 @@
 Version History
 ===============
-0.7.2 (2017-06-03)
+0.7.3 (2017-06-06)
+------------------
+ - The error was introduced in 0.7.1, redeclaring ``error``. Fix that.
+
+0.7.2 (2017-06-06)
 ------------------
  - What type of error is it if it has no response? Odd.
-0.7.1 (2017-06-02)
+0.7.1 (2017-06-05)
 ------------------
  - Getting error response back that we can't decode, log it

setup.py

@@ -39,7 +39,7 @@ def read_requirements(name):
 setuptools.setup(
     name='tornado-aws',
-    version='0.7.2',
+    version='0.7.3',
     description=DESC,
     long_description=open('README.rst').read(),
     author='Gavin M. Roy',

tornado_aws/__init__.py

@@ -6,6 +6,6 @@ from tornado_aws.client import AWSClient
 from tornado_aws.client import AsyncAWSClient
 from tornado_aws.client import exceptions
-__version__ = '0.7.2'
+__version__ = '0.7.3'
 __all__ = ['AWSClient', 'AsyncAWSClient', 'exceptions']

tornado_aws/client.py

@@ -183,15 +183,13 @@ class AWSClient(object):
         """
         if not isinstance(error, httpclient.HTTPError):
             return
-        elif not hasattr(error, 'response'):
-            LOGGER.error('Error has no response: %r', error)
-            return
-        if error.code == 400:
+        if error.code >= 400 and error.response is not None:
             try:
                 payload = json.loads(error.response.body.decode('utf-8'))
-            except json.JSONDecodeError as error:
-                LOGGER.error('Error decoding response: %r [%r]',
-                             error.response, error.response.body)
+            except (AttributeError, json.JSONDecodeError) as err:
+                LOGGER.error('Error decoding response as JSON (%s): %r %r',
+                             err, error.response,
+                             getattr(error.response, 'body', None))
                 return
             if isinstance(payload, dict) and '__type' in payload:
                 return payload