Don't allow saving broken images, as it just saves the broken image icon. Issue 5971

sources/PTYTextView.m

@@ -4618,7 +4618,7 @@ static double EuclideanDistance(NSPoint p1, NSPoint p2) {
     // Allocate a menu
     theMenu = [[[NSMenu alloc] initWithTitle:@"Contextual Menu"] autorelease];
     iTermImageInfo *imageInfo = [self imageInfoAtCoord:coord];
-    if (imageInfo) {
+    if (imageInfo && !imageInfo.broken) {
         // Show context menu for an image.
         NSArray *entryDicts =
             @[ @{ @"title": @"Save Image As…",

sources/VT100Screen.m

@@ -11,6 +11,7 @@
 #import "iTermExpose.h"
 #import "iTermGrowlDelegate.h"
 #import "iTermImage.h"
+#import "iTermImageInfo.h"
 #import "iTermImageMark.h"
 #import "iTermURLMark.h"
 #import "iTermPreferences.h"
@@ -3411,7 +3412,8 @@ static NSString *const kInilineFileInset = @"inset";  // NSValue of NSEdgeInsets
     } else {
         image = [iTermImage imageWithCompressedData:data];
     }
-    if (!image) {
+    const BOOL isBroken = !image;
+    if (isBroken) {
         image = [iTermImage imageWithNativeImage:[NSImage imageNamed:@"broken_image"]];
         assert(image);
     }
@@ -3500,6 +3502,8 @@ static NSString *const kInilineFileInset = @"inset";  // NSValue of NSEdgeInsets
                                            height,
                                            preserveAspectRatio,
                                            fractionalInset);
+    iTermImageInfo *imageInfo = GetImageInfo(c.code);
+    imageInfo.broken = isBroken;
     for (int y = 0; y < height; y++) {
         if (y > 0) {
             [self linefeed];

sources/iTermImageInfo.h

@@ -56,6 +56,9 @@ extern NSString *const iTermImageDidLoad;
 // Creates a pasteboard item that responds with image or file.
 @property(nonatomic, readonly) NSPasteboardItem *pasteboardItem;
+// Is this a broken image?
+@property(nonatomic) BOOL broken;
+
 // Used to create a new instance for a new image. This may remain an empty container until
 // -setImageFromImage: is called.
 - (instancetype)initWithCode:(unichar)code;

sources/iTermImageInfo.m

@@ -22,6 +22,7 @@ static NSString *const kImageInfoPreserveAspectRatioKey = @"Preserve Aspect Rati
 static NSString *const kImageInfoFilenameKey = @"Filename";
 static NSString *const kImageInfoInsetKey = @"Edge Insets";
 static NSString *const kImageInfoCodeKey = @"Code";
+static NSString *const kImageInfoBrokenKey = @"Broken";
 NSString *const iTermImageDidLoad = @"iTermImageDidLoad";
@@ -51,6 +52,7 @@ NSString *const iTermImageDidLoad = @"iTermImageDidLoad";
     self = [super init];
     if (self) {
         _size = [dictionary[kImageInfoSizeKey] sizeValue];
+        _broken = [dictionary[kImageInfoBrokenKey] boolValue];
         _inset = [dictionary[kImageInfoInsetKey] futureEdgeInsetsValue];
         _data = [dictionary[kImageInfoImageKey] retain];
         _dictionary = [dictionary copy];
@@ -202,7 +204,8 @@ NSString *const iTermImageDidLoad = @"iTermImageDidLoad";
               kImageInfoImageKey: _data ?: [NSData data],
               kImageInfoPreserveAspectRatioKey: @(_preserveAspectRatio),
               kImageInfoFilenameKey: _filename ?: @"",
-              kImageInfoCodeKey: @(_code)};
+              kImageInfoCodeKey: @(_code),
+              kImageInfoBrokenKey: @(_broken) };
 }