Skip to content
Snippets Groups Projects
Commit 8dca4b36 authored by George Nachman's avatar George Nachman
Browse files

Move beta users to unicode 9 widths by default

parent 8b1966cd
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -382,7 +382,12 @@ NSString *const kProfilePreferenceInitialDirectoryAdvancedValue = @"Advanced";
static NSDictionary *dict;
if (!dict) {
dict = @{ KEY_IDLE_PERIOD: PROFILE_BLOCK(antiIdlePeriodWithLegacyDefaultInProfile),
KEY_UNICODE_NORMALIZATION: PROFILE_BLOCK(unicodeNormalizationForm) };
KEY_UNICODE_NORMALIZATION: PROFILE_BLOCK(unicodeNormalizationForm),
#if BETA
// TODO: If beta users don't complain too much turn this on for everyone.
KEY_UNICODE_VERSION: PROFILE_BLOCK(unicodeVersion),
#endif
};
[dict retain];
}
return dict;
Loading
Loading
@@ -443,4 +448,23 @@ NSString *const kProfilePreferenceInitialDirectoryAdvancedValue = @"Advanced";
return [self defaultObjectForKey:key];
}
 
+ (id)unicodeVersion:(Profile *)profile {
NSString *const key = KEY_UNICODE_VERSION;
// If the profile has a value.
NSNumber *value = profile[key];
if (value) {
return value;
}
if (@available(macOS 10.13, *)) {
// macOS 10.13 has switched to unicode 9 widths. If you're sshing somewhere then you're
// going to have a bad time. My hope is that this makes people happier on balance.
return @9;
} else {
// Fall back to the default from the dictionary.
return [self defaultObjectForKey:key];
}
}
@end
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment