Add a context menu to the password manager with a Reveal Password item. Double...

Add a context menu to the password manager with a Reveal Password item. Double click always sends the password now. Issue 5912.

Interfaces/iTermPasswordManager.xib

-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="7531" systemVersion="14E46" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none">
+<?xml version="1.0" encoding="UTF-8"?>
+<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="11762" systemVersion="16E195" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none">
     <dependencies>
-        <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="7531"/>
+        <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="11762"/>
+        <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
     </dependencies>
     <objects>
         <customObject id="-2" userLabel="File's Owner" customClass="iTermPasswordManagerWindowController">
@@ -30,11 +31,11 @@
                         <rect key="frame" x="20" y="49" width="465" height="261"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <clipView key="contentView" id="yan-v0-dhd">
-                            <rect key="frame" x="1" y="17" width="463" height="243"/>
+                            <rect key="frame" x="1" y="0.0" width="463" height="260"/>
                             <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                             <subviews>
                                 <tableView verticalHuggingPriority="750" allowsExpansionToolTips="YES" columnAutoresizingStyle="firstColumnOnly" alternatingRowBackgroundColors="YES" columnReordering="NO" columnSelection="YES" multipleSelection="NO" autosaveColumns="NO" headerView="7EL-It-qNK" id="JC7-GD-2vC">
-                                    <rect key="frame" x="0.0" y="0.0" width="463" height="19"/>
+                                    <rect key="frame" x="0.0" y="0.0" width="463" height="243"/>
                                     <autoresizingMask key="autoresizingMask"/>
                                     <size key="intercellSpacing" width="3" height="2"/>
                                     <color key="backgroundColor" name="controlBackgroundColor" catalog="System" colorSpace="catalog"/>
@@ -70,10 +71,10 @@
                                     <connections>
                                         <outlet property="dataSource" destination="-2" id="1wd-hR-ATJ"/>
                                         <outlet property="delegate" destination="-2" id="mkh-gw-YCa"/>
+                                        <outlet property="menu" destination="9eU-Sx-UCv" id="z2h-I6-qNc"/>
                                     </connections>
                                 </tableView>
                             </subviews>
-                            <color key="backgroundColor" name="controlBackgroundColor" catalog="System" colorSpace="catalog"/>
                         </clipView>
                         <scroller key="horizontalScroller" hidden="YES" verticalHuggingPriority="750" horizontal="YES" id="JBn-Xm-o7X">
                             <rect key="frame" x="1" y="1" width="0.0" height="16"/>
@@ -167,6 +168,17 @@ Gw
                 <outlet property="delegate" destination="-2" id="rtX-Z4-Dgp"/>
             </connections>
         </window>
+        <menu id="9eU-Sx-UCv">
+            <items>
+                <menuItem title="Reveal Password" id="dYf-3U-Qz3">
+                    <modifierMask key="keyEquivalentModifierMask"/>
+                    <connections>
+                        <action selector="revealPassword:" target="-2" id="afJ-HM-r97"/>
+                    </connections>
+                </menuItem>
+            </items>
+            <point key="canvasLocation" x="-482" y="379"/>
+        </menu>
     </objects>
     <resources>
         <image name="NSAddTemplate" width="11" height="11"/>

sources/iTermPasswordManagerWindowController.m

@@ -205,12 +205,7 @@ static BOOL sAuthenticated;
 }
 - (void)doubleClickOnTableView:(id)sender {
-    if ([_tableView clickedColumn] == 1) {
-        if (!_passwordBeingShown && [_tableView selectedRow] >= 0) {
-            [self setPasswordBeingShown:[self selectedPassword] onRow:[_tableView selectedRow]];
-            [_tableView reloadData];
-        }
-    } else if ([_tableView selectedRow] >= 0) {
+    if ([_tableView selectedRow] >= 0) {
         [self enterPassword:nil];
     }
 }
@@ -266,6 +261,13 @@ static BOOL sAuthenticated;
     }
 }
+- (IBAction)revealPassword:(id)sender {
+    if (!_passwordBeingShown && [_tableView selectedRow] >= 0) {
+        [self setPasswordBeingShown:[self selectedPassword] onRow:[_tableView selectedRow]];
+        [_tableView reloadData];
+    }
+}
+
 #pragma mark - Private
 - (Class)keychain {