Skip to content
Snippets Groups Projects
Commit ad738778 authored by George Nachman's avatar George Nachman
Browse files

Validate characters in ssh URL user name

parent 168d0eee
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -1003,7 +1003,16 @@ static iTermController *gSharedInstance;
 
if ([urlType compare:@"ssh" options:NSCaseInsensitiveSearch] == NSOrderedSame) {
NSMutableString *tempString = [NSMutableString stringWithString:@"ssh "];
if ([urlRep user]) {
NSString *username = [urlRep user];
if (username) {
NSMutableCharacterSet *legalCharacters = [NSMutableCharacterSet alphanumericCharacterSet];
[legalCharacters addCharactersInString:@"_-+"];
NSCharacterSet *illegalCharacters = [legalCharacters invertedSet];
NSRange range = [username rangeOfCharacterFromSet:illegalCharacters];
if (range.location != NSNotFound) {
ELog(@"username %@ contains illegal character at position %@", username, @(range.location));
return nil;
}
[tempString appendFormat:@"-l %@ ", [[urlRep user] stringWithEscapedShellCharactersIncludingNewlines:YES]];
}
if ([urlRep port]) {
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment