Skip to content
Snippets Groups Projects
Commit d2cbe752 authored by George Nachman's avatar George Nachman
Browse files

Fix a bug when a dynamic profile inherits from a profile with the deprecated...

Fix a bug when a dynamic profile inherits from a profile with the deprecated preference KEY_DEFAULT_BOOKMARK set to yes, which would cause it to possibly become the default profile. Issue 4115.
parent 17319d9a
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -249,6 +249,9 @@
Profile *prototype = [self prototypeForDynamicProfile:profile];
NSMutableDictionary *merged = [self profileByMergingProfile:profile
intoProfile:prototype];
// Don't inherit the deprecated KEY_DEFAULT_BOOKMARK value, which in issue 4115 we learn can
// cause a dynamic profile to become the default profile!
[merged removeObjectForKey:KEY_DEFAULT_BOOKMARK];
[merged profileAddDynamicTagIfNeeded];
 
[[ProfileModel sharedInstance] addBookmark:merged];
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment