Make the duration of 'short-lived' sessions configurable by an advanced pref. Issue 5165 comment

sources/PTYSession.m

@@ -1606,7 +1606,7 @@ ITERM_WEAKLY_REFERENCEABLE
         // The applescript test driver doesn't care about short-lived sessions.
         return;
     }
-    if ([[NSDate date] timeIntervalSinceDate:_creationDate] < 3) {
+    if ([[NSDate date] timeIntervalSinceDate:_creationDate] < [iTermAdvancedSettingsModel shortLivedSessionDuration]) {
         NSString* theName = [_profile objectForKey:KEY_NAME];
         NSString *guid = _profile[KEY_GUID];
         if (_originalProfile && [_originalProfile[KEY_GUID] length]) {

sources/iTermAdvancedSettingsModel.h

@@ -171,5 +171,6 @@
 + (void)setNoSyncSuppressMissingProfileInArrangementWarning:(BOOL)value;
 + (BOOL)acceptOSC7;
 + (BOOL)trackingRunloopForLiveResize;
++ (double)shortLivedSessionDuration;
 @end

sources/iTermAdvancedSettingsModel.m

@@ -201,6 +201,7 @@ DEFINE_BOOL(noSyncSuppressCaptureOutputToolNotVisibleWarning, NO,
 DEFINE_BOOL(closingTmuxWindowKillsTmuxWindows, NO, @"Warnings: Suppress kill/hide dialog when closing a tmux window.");
 DEFINE_BOOL(closingTmuxTabKillsTmuxWindows, NO, @"Warnings: Suppress kill/hide dialog when closing a tmux tab.");
 DEFINE_BOOL(aboutToPasteTabs, NO, @"Warnings: Suppress warning about pasting tabs with offer to convert them to spaces.");
+DEFINE_FLOAT(shortLivedSessionDuration, 3, @"Warnings: Warn about short-lived sessions that live less than this many seconds.");
 DEFINE_SETTABLE_BOOL(noSyncDoNotWarnBeforeMultilinePaste, NoSyncDoNotWarnBeforeMultilinePaste, NO, @"Warnings: Suppress warning about multi-line pastes (or a single line ending in a newline).\nThis applies whether you are at the shell prompt or not, provided two or more lines are being pasted.");
 DEFINE_SETTABLE_BOOL(noSyncDoNotWarnBeforePastingOneLineEndingInNewlineAtShellPrompt, NoSyncDoNotWarnBeforePastingOneLineEndingInNewlineAtShellPrompt, NO, @"Warnings: Suppress warning about pasting a single line ending in a newline when at the shell prompt.\nThis requires Shell Integration to be installed.");