Skip to content
Snippets Groups Projects
  1. Dec 02, 2017
    • George Nachman's avatar
      Fix a bug where hotkey windows appearing in a different display than the... · 02e75fef
      George Nachman authored
      Fix a bug where hotkey windows appearing in a different display than the currently key window (in another app) would not receive focus and would forget which app was previously active. Issue 6353
      
      The two key changes are
      1. Add a method to activate the app with a completion block
      2. Don't throw away the existing previous state when a non hotkey window becomes key during a rollin. The logic already existed for a rollout.
      Here's what would happen:
      
      rollInAnimated
        [NSApp activateIgnoringOtherApps:YES]
        rollInAnimatingInDirection:
      (if there's no animation, the rollin finishes immediately)
      App becomes active
      A non-hotkey window becomes key
      
      Now, here's what happens:
      
      rollInAnimated
        [NSApp activateIgnoringOtherApps:YES]
      App becomes active
      A non-hotkey window becomes key, but it's ignored because there's a roll-in in progress
      rollInAnimatingInDirection:
      (if there's no animation, the rollin finishes immediately)
      02e75fef
  2. Jul 02, 2017
  3. Jun 30, 2017
  4. Jun 02, 2017
  5. Mar 24, 2017
  6. Mar 04, 2017
  7. Feb 20, 2017
  8. Feb 14, 2017
  9. Jan 01, 2017
    • George Nachman's avatar
      Make it possible to save a hotkey window in a saved arrangement. Fix a bug... · 88d0522c
      George Nachman authored
      Make it possible to save a hotkey window in a saved arrangement. Fix a bug where restored hotkey windows get an extra tab. I'm a little nervous about what this change might break, but I tested it and it plays nice with session restoration, default arrangements, and explicit saved arranagement restoration whether there's already a hotkey window or not. Issue 4924.
      88d0522c
  10. Dec 28, 2016
    • George Nachman's avatar
      After a hotkey window rolls out we wait half a second for the previously... · d66f8420
      George Nachman authored
      After a hotkey window rolls out we wait half a second for the previously active app to become active. This is because activating another app is slow. During that period you could not re-open the hotkey window. This commit introduces the idea of canceling a hotkey window rollout. It is cancelable after the animation and during the half-second window. When you cancel the rollout it becomes possible to roll in again. The other app will eventually become active so we wait half a second and if iTerm2 still isn't active and the window isn't rolling out then we make iTerm2 active again. Issue 5423.
      d66f8420
  11. Dec 21, 2016
    • George Nachman's avatar
      Add new applescript for hotkey windows. Commands that windows recognize now include: · 8c7c282b
      George Nachman authored
      - is hotkey window
      - hotkey window profile
      - reveal hotkey window
      - hide hotkey window
      - toggle hotkey window
      
      The application now understands:
      - create hotkey window with profile xxx
      
      If a hotkey window does not yet exist, you must create it. If it does exist, it
      can't be created again but you can change its visibility. Recommended usage is
      to iterate over the app's "windows" properties and search for the hotkey window
      you care about by asking each window if it "is hotkey window" and if its
      "hotkey window profile" is the one you're looking for. If none is found, use
      "create hotkey window with profile xxx". Otherwise, use "reveal hotkey window".
      8c7c282b
  12. Dec 03, 2016
    • George Nachman's avatar
      Fix a bug where a non-hotkey window would briefly appear when hiding a hotkey... · ff4fe501
      George Nachman authored
      Fix a bug where a non-hotkey window would briefly appear when hiding a hotkey and activating another app because we ordered out the invisible hotkey window before activating the other app. The OS ordered front a non-hotkey window just before the other app was activated. Fixing this (which means making the order-out happen after the app switch) had a bunch of knock on effects when there were multiple windows with the same hotkey, which this commit attempts to address by batching up changes to multiple hotkey windows and making the showing and hiding of "siblings" (windows with the same hotkey) more explicit. Brought up in a comment in issue 5313.
      ff4fe501
    • George Nachman's avatar
      Fix a bug where the previously active app was not restored after pressing a... · bae7fd83
      George Nachman authored
      Fix a bug where the previously active app was not restored after pressing a hotkey that hides two different hotkey windows. The previous state with a previously active app got overwritten by one that did not have a previously active app.
      bae7fd83
  13. Oct 23, 2016
  14. Sep 26, 2016
    • George Nachman's avatar
      Make the "screen with cursor" preference cause hotkey windows to appear on · 04825fb9
      George Nachman authored
      the screen that currently has the cursor. Issue 3374.
      
      Revamps the logic for picking the screen to canonicalize the frame to.
      Affects the screen used by fitWIndowToTabs. This probably has unintended
      consequences but the code is more readable now and there should be fewer
      cases where the window randomly moves to the main screen.
      04825fb9
    • George Nachman's avatar
      Make the "screen with cursor" preference cause hotkey windows to appear on · 943a062b
      George Nachman authored
      the screen that currently has the cursor.
      
      Revamps the logic for picking the screen to canonicalize the frame to.
      Affects the screen used by fitWIndowToTabs. This probably has unintended
      consequences but the code is more readable now and there should be fewer
      cases where the window randomly moves to the main screen.
      943a062b
  15. Aug 06, 2016
  16. Jul 16, 2016
Loading