Skip to content
Snippets Groups Projects
  1. May 13, 2017
  2. Jan 02, 2017
    • George Nachman's avatar
      Use sudo's method (and code) to close file descriptors instead of iterating... · f6b54d66
      George Nachman authored
      Use sudo's method (and code) to close file descriptors instead of iterating over every possible file descritor. In issue 5391 we see that closing file descriptors can take a very long time: 4 seconds in this user's case. We now close file descriptors in the file descriptor server before fork(). Since the file descriptor server is single-threaded, this works and is safe. Sudo uses opendir() after fork() which could deadlock, which we don't want to risk (and is a more serious concern for us since we're multithreaded) so when session restoration is disabled we still close every file descriptor because that's the state of the art on macOS (sigh).
      f6b54d66
  3. Aug 12, 2016
  4. Mar 20, 2016
  5. Mar 07, 2016
  6. Mar 01, 2016
  7. Jun 10, 2015
  8. Jun 08, 2015
  9. Jun 06, 2015
  10. Jun 01, 2015
  11. Apr 06, 2015
  12. Sep 21, 2014
  13. Mar 30, 2014
    • George Nachman's avatar
      Increase warning levels and fix warnings. The only inexcusably disabled... · 8778c638
      George Nachman authored
      Increase warning levels and fix warnings. The only inexcusably disabled warning (possibly) is for comparisons of different signs, simply because there are so many of them, in large part because methods like -count and -length return unsigned integers. IMO, the proliferation of unsigned ints is more dangerous than turning off the warning.
      8778c638
  14. Sep 16, 2013
Loading