Refactor timer stuff into a single file.

Defer decreasing the frame rate until the next frame is drawn to try to avoid issues like 5928.

Allow more services (those that do not produce input and those that accept input) to appear in the services menu. Issue 5942

Fix a bug in regex search where a regex like xa* would return multiple search results against a document like xaaaa (xa, xaa, etc.). Now that search results are properly sorted, this causes strange behavior. For example, only part of a match might be selected. Now, we ignore results that are a subset of a previous result. This works because the search progressively shortens and re-searches the document (e.g., xaaa, xaa, xa, x). Issue 5937

Fix a bug where coords and content would not be in 1:1 correspondence when an url action is found and hard newlines are ignored (set by an advanced pref, which is not the default setting). Remove the corresponding coords as well as the newlines from the string. Issue 5929.

Fix a bug where triggers would highlight lookahead matches. Only the first range needs to be highlighted. That's the range of the string that matched the pattern. Additional ranges correspond to captures, not all of which are necessarily contained in the first range. Lookaheads fall outside the matched range and should not be highlihgted. Issue 5934.

Fix a bug where the newline policy kiTermTextExtractorNullPolicyFromLastToEnd would include a leading newline after removing text prior to a null. This caused URL actions to detect a region that began one cell early. That null policy is only used in URL action detection.

Issue 5929

Change how adjacent sessions are found. The previous algorithm could loop forever if things weren't laid out correctly, and I think there are subtle bugs in how the split views' subviews get laid out.
Issue 5932

Add new thin strokes settings to enable it with light backgrounds. People who had Always or Retina are migrated to With Dark Backgrounds or Retina and Dark Backgrounds, respectively. Issue 5910.

Make the app hotkey remember the previously active app so it can switch back to it from a lion fullscreen window. Issue 5925.

Respect changes to the preferred screen of a profile with an existing hotkey window. Update the window controller's copy of the preferred screen setting. Only hotkey windows are affected since other kinds of windows do not move from screen to screen after their initial creation. Issue 5923.

Disable the zippy text drawing algorithm for cells that have combining marks or surrogate pairs. CG draws combining marks really badly; core text is slow but much better.

Disable fastpath drawing for box-drawing characters.

This should fix the failing tests.

Fixed typo in "Minimum contrast" slider.

For key actions that open a menu item, modify the parameter value to include a unique identifier for the menu item. Previously the parameter value was the title. That was bad because renaming a title would break an existing action. Titles are also ambiguous because they're duplicated between Restore Arrangement and Restore Arrangement as Tabs. Parameter values now may take one of two forms:

Title

or

Title + newline + identifier

If an identifier is present and the OS is 10.12+ (which has proper identifier on menu item support) then the title will be ignored when searching for a match.

Issue 5914.

Fix a bug where the first scheme in the list of URL schemes was not selectable because NSMenu is stupid. Issue 5897 (in a comment)

Add a context menu to the password manager with a Reveal Password item. Double click always sends the password now. Issue 5912.

Refactor event taps. Fixes a bug: if we couldn't register the keydown event tap for lack of permissions, we also wouldn't register the flags-changed event tap (since we want all remapping to happen in sendEvent:). But that broke double-tap to open a hotkey window. In this commit, there is a separate object for keydown vs modifier changed event taps. The modifier-changed event tap is shared between the modifier remapper and the hotkey code. If we don't have permission for accessibility, the modifier remapper knows it and remapping goes through sendEvent:. It seems we can always register the flags changed event tap. Issue 5911.

Hold option to scroll into history while in alternate screen when scroll wheel is in send-arrow-keys-in-alt-screen mode

hole.

Disable ligatures by default. Performance sucks using core text and I don't see a way to improve it without using all kinds of private APIs. The only difference I can find between us and Terminal is that they have a very flat view hierarchy. They don't use NSScrollView. I can't ditch NSScrollView because I can't cobble together a frankenstein from its parts the way Apple can.

Register for the keydown and flags-changed event taps separately. If you lack accessibility permission then the flags-changed event tap succeeds and keydown fails, but it doesn't let you know. This means you don't get modifiers remapped but the app thinks they are getting remapped since an event tap exists. Issue 5902.

slow, these fonts are commonly used, and they never have ligatures. I still
need to update the UI to hide the ligature box for them.

Also simplify how we detect ligature level 2 fonts, which are all Iosevka.

Fix bug where Applescript 'current window' would crash if there was no current window because the _underlyingWindow would be nil.

Issue 5899

Don't try to make the window content size an exact multiple of cell size when standardizing the frame. This causes too much confusion for little benefit. Issue 5892.

When you tap the touch bar button to view a man page on a command that does not have a man page, man will return an error. The window would close immediately. Modify the default man page command to wait a few seconds on error so you can see what went wrong.

Issue 5891