Remove mechanism for catching proc_pidinfo and statfs timeouts. It was causing crashes, but I don't understand why. Perhaps mixing ARC and non-ARC code has some problem? I saw lots of crashes on 3.1.4 where proc_pidinfo exceeded the timeout and when it finally returned there was heap corruption. It looked as though the dispatch group had been freed even though there was an outstanding reference to it. At any rate, if proc_pidinfo is hanging you're going to have a bad time even without this workaround.

Fix a bug where openFile:inEditorWithBundleId:lineNumber: ignored its identifier argument, using self.preferredEditorIdentifier instead. This broke opening a file with a line number in the default app, as seen in issue 4386.

The main motivation for this change is that git when presenting merge
conflicts sometimes shows the file paths in single quotes. Instead of
just adding single quotes, I thought it was just as well to add some
other delimiters that are unlikely to appear in file names

Make whitespace trimming optional when semantic history is picking apart the chunks of a file. Whitespace trimming was added always-on to improve how semantic history located filenames in selections for Open Selection, but that introduced a bug where the holding cmd while the mouse is over whitespace preceding a filename would cause some of the whitespace to be considered a match and a corresponding number of characters from the suffix of the file not to be underlined. Issue 3841..

* Do not try to guess the type of a file. In the past, if file(1) suggested the file might be a text file then we’d open it in the editor of our choosing. Now, we open it in your default editor. If it’s one we recognize and you clicked a reference with a line number, we open it to that line number.

* Add an explicit option for Textmate 2 in the editor picker. We used to try to cleverly open the “right” version of textmate, but that made the other part of this commit not work so well.

See issue 3569 for discussion.

Strip out parens earlier in semantic history to make it possible to click in the filename in a string like this: prefix(filename:123)

When you've elected to use an editor in semantic history, always use it. The previous logic was nonsensical. Also, when opening a text file with the default semantic history action and the registered app for the file happens to be the preferred editor, pass the line number along.