Skip to content
Snippets Groups Projects
  1. Aug 13, 2017
  2. Sep 01, 2016
    • George Nachman's avatar
      Decode images out of process. This is for improved security because buffer... · 99f1240c
      George Nachman authored
      Decode images out of process. This is for improved security because buffer overflows when decoding images are a real risk. This commit adds a new executable, image_decoder, which reads a compressed image on fd 0 and writes JSON describing its frames, sizes, and delays (for animated GIFs) on fd 1. When an image is received, the image_decoder job is run in a sandbox. Likewise, when iTerm2 restores saved state, image_decoder again decodes each image. In this way images that were not in our control are always passed through image_decoder. Some images, like the broken pipe graphic, are under our control and do not need to be decoded out of process. When restoring state, one image at a time is decoded in order of most recently requested. This provides adequate performance while minimizing latency.
      99f1240c
  3. Aug 31, 2016
    • George Nachman's avatar
      Decode images out of process. This is for improved security because buffer... · 8d1d97dc
      George Nachman authored
      Decode images out of process. This is for improved security because buffer overflows when decoding images are a real risk. This commit adds a new executable, image_decoder, which reads a compressed image on fd 0 and writes JSON describing its frames, sizes, and delays (for animated GIFs) on fd 1. When an image is received, the image_decoder job is run in a sandbox. Likewise, when iTerm2 restores saved state, image_decoder again decodes each image. In this way images that were not in our control are always passed through image_decoder. Some images, like the broken pipe graphic, are under our control and do not need to be decoded out of process. When restoring state, one image at a time is decoded in order of most recently requested. This provides adequate performance while minimizing latency.
      8d1d97dc
  4. Jun 19, 2016
  5. Apr 08, 2016
  6. Mar 21, 2016
  7. May 12, 2015
    • George Nachman's avatar
      Add support for animated GIFs and in the process clean up some of the stuff... · 5dc40316
      George Nachman authored
      Add support for animated GIFs and in the process clean up some of the stuff around how images are handled:
      * Move responsiblity for creating a pasteboard item and saving a temp file into ImageInfo.
      * Make mouse become a cursor when over an image.
      * Make cmd-click on an image open it.
      * Move ImageInfo into its own file.
      * Also clean up a bogus method in a PSM header.
      
      Cleanup
      5dc40316
Loading