Disable the zippy text drawing algorithm for cells that have combining marks or surrogate pairs. CG draws combining marks really badly; core text is slow but much better.

Disable fastpath drawing for box-drawing characters.

This should fix the failing tests.

Fixed typo in "Minimum contrast" slider.

For key actions that open a menu item, modify the parameter value to include a unique identifier for the menu item. Previously the parameter value was the title. That was bad because renaming a title would break an existing action. Titles are also ambiguous because they're duplicated between Restore Arrangement and Restore Arrangement as Tabs. Parameter values now may take one of two forms:

Title

or

Title + newline + identifier

If an identifier is present and the OS is 10.12+ (which has proper identifier on menu item support) then the title will be ignored when searching for a match.

Issue 5914.

Fix a bug where the first scheme in the list of URL schemes was not selectable because NSMenu is stupid. Issue 5897 (in a comment)

Add a context menu to the password manager with a Reveal Password item. Double click always sends the password now. Issue 5912.

Refactor event taps. Fixes a bug: if we couldn't register the keydown event tap for lack of permissions, we also wouldn't register the flags-changed event tap (since we want all remapping to happen in sendEvent:). But that broke double-tap to open a hotkey window. In this commit, there is a separate object for keydown vs modifier changed event taps. The modifier-changed event tap is shared between the modifier remapper and the hotkey code. If we don't have permission for accessibility, the modifier remapper knows it and remapping goes through sendEvent:. It seems we can always register the flags changed event tap. Issue 5911.

Hold option to scroll into history while in alternate screen when scroll wheel is in send-arrow-keys-in-alt-screen mode

hole.

Disable ligatures by default. Performance sucks using core text and I don't see a way to improve it without using all kinds of private APIs. The only difference I can find between us and Terminal is that they have a very flat view hierarchy. They don't use NSScrollView. I can't ditch NSScrollView because I can't cobble together a frankenstein from its parts the way Apple can.

Register for the keydown and flags-changed event taps separately. If you lack accessibility permission then the flags-changed event tap succeeds and keydown fails, but it doesn't let you know. This means you don't get modifiers remapped but the app thinks they are getting remapped since an event tap exists. Issue 5902.

slow, these fonts are commonly used, and they never have ligatures. I still
need to update the UI to hide the ligature box for them.

Also simplify how we detect ligature level 2 fonts, which are all Iosevka.

Fix bug where Applescript 'current window' would crash if there was no current window because the _underlyingWindow would be nil.

Issue 5899

Don't try to make the window content size an exact multiple of cell size when standardizing the frame. This causes too much confusion for little benefit. Issue 5892.

When you tap the touch bar button to view a man page on a command that does not have a man page, man will return an error. The window would close immediately. Modify the default man page command to wait a few seconds on error so you can see what went wrong.

Issue 5891

Fix a bug where a buried tmux gateway could not relay title changed notifications to the proper PTYTab because it lacks a delegate.
Issue 5890

Make a copy of the raw line block data in -[LineBlock dictionary]. It looks like OS 10.13 needs the data in the coder asynchronously. This was always a risky optimization. It used to work because nothing could be mutated between willEncode and the actual encoding, but it seems that is no longer the case.

Prevent text extractor's line cache from outliving the vcall to performBlockWithLineCache, which caused a test to access freed memory

Issue 5884

Show a warning if the shortcut to toggle the app is the same as the shortcut to toggle a profile window.

Also fix a bug where duplicate warnings wouldn't be shown if some irrelevant modifier flag bits were set.

Issue 5882

Tmux 2.1 and earlier throw an error when you give new-window -c a bogus directory. Improve our error reporting in this case and in all cases to show the command response.
Issue 5847

When the theme is dark and window titles are dark then use a dark background for the toolbelt. A comment by joshuajabbour in issue 3314.

When rolling a hotkey window in or out, do not animate it so that it begins or ends (respectively) on another screen. When screens have their own spaces windows can't span displays and the setting of the initial/final frame does something unexpected (like choosing a different frame in a completely different place). Issue 5871.

Remove logging calls from MyLoginTTY, which runs between fork and exec. This was the likely culprit in a crash. Issue 5866.

- Resizing a session would clear the find state, removing search results until the next search
- Clearing a buffer would remove highlights but not search results so they wouldn't reappear

Issue 5865.