Allow undo close session

By gnach... on May 05, 2014 20:17 (imported from Google Code)

---

After a session closes, you'd have N seconds to undo closing it. This should probably be off by default.

Rather than calling -terminate on user-initiated closes, we'd need to:

1. Tell the session that it's suspended. This would disable things like popping modal alert boxes.
2. Remove its file descriptor from the select loop.
3. Add it to a suspended-sessions list.
4. Start a N-second timer.

When the timer fires, call -terminate as usual. If the user selects edit>undo close session then open it as a new tab in the current window. Trying to restore it as a split pane if it had been one would be very difficult if the tab's arrangement of split panes had changed.

Stretch goal: have a long-running daemon that gets a copy of all file descriptors so sessions can survive a crash.

Milestone changed to Future Release

This is a cool feature, but it would be nice if the undone tab opened in the same place where it was originally.

Milestone changed to Ship 3.0

For the most part it does, but there are edge cases where it might not. What are your steps to reproduce the tab opening in the wrong place?

I just close a tab and cmd-z, and it opens on the right of the tab bar instead of where it was. I'm on Build 2.9.20150622-nightly.

Right you are. Fixed in commit 855f8165.

Status changed to closed