shell integration: pressing ctrl-c while typing a shell command (aborting) should not add to the toolbelt command history

ctrl-c abort the current shell command input. I'm seeing all my aborted command show up in the command history toolbelt. I'm starting to realize to my dismay how often screw up in the terminal!

Also, this is an awesome update to an already amazing program. Keep up the good work!

I can't reproduce this issue. Could you provide a debug log? Instructions are here: iterm2.com/debuglog

https://www.dropbox.com/s/9u63ziji7i91sg0/Screenshot%202016-02-22%2015.00.49.png?dl=0

(screenshot was taken one “clear” command after debug logging ended)debuglog.txt

What shell do you use? I'll need to add some debugging to the shell integration script to see what's going on, but each shell has a different one.

Milestone changed to Ship 3.0

plain unmodified bash

@egradman Please follow these steps:

1. Temporarily replace your $HOME/.iterm2_shell_integration.bash with the contents of this file:

https://gist.githubusercontent.com/gnachman/deca4052603129789cb1/raw/a9b99b8f0cfbef7c191de4b432df033c1ece9e7c/gistfile1.txt

2. Open a new window
3. Run the date command
4. Type xxx and then hit ^C
5. Paste the output in this issue.

Status changed to closed

Status changed to reopened

Last login: Tue Feb 23 20:50:04 on ttys007
(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin preexec invoke cmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(before calling precmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(after returning from precmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(end preexec invoke cmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-prompt-prefix)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(end-prompt-prefix)erics-MacBook-Pro-2:~ egradman$ (begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-prompt-suffix)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-prompt-prefix)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(end-prompt-prefix)erics-MacBook-Pro-2:~ egradman$ (begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-prompt-suffix)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(end-prompt-suffix)date
(begin-preexec-invoke-exec)(in subshell)(before calling preexec)(begin-preexec)(end-preexec)(after calling preexec)Tue Feb 23 20:51:35 PST 2016
(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin preexec invoke cmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(before calling precmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(after returning from precmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(set orig_ps1)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(end preexec invoke cmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-prompt-prefix)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(end-prompt-prefix)erics-MacBook-Pro-2:~ egradman$ (begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-prompt-suffix)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(end-prompt-suffix)xxx
(begin-preexec-invoke-exec)(in subshell)(before calling preexec)(begin-preexec)(end-preexec)(after calling preexec)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin preexec invoke cmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(before calling precmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(after returning from precmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(set orig_ps1)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(end preexec invoke cmd)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(NOT INTERACTIVE MODE)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-prompt-prefix)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(end-prompt-prefix)erics-MacBook-Pro-2:~ egradman$ (begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-prompt-suffix)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(begin-preexec-invoke-exec)(IN PIPED SUBSHELL)(end-prompt-suffix)

I was able to reproduce this on a CentOS 7.2 box. It happens because on some bashes precmd runs but preexec does NOT when you press ^C.

I think I have this fixed in commit 89509ed of the iterm2-website repo.

Please test it! This is a scary change. Here's what to do:

1. Download this file: https://raw.githubusercontent.com/gnachman/iterm2-website/master/source/misc/bash_startup.in
2. Temporarily copy it over $HOME/.iterm2_shell_integration.bash.

Live with it for a few days and let me know if any new problems crop up.

Status changed to closed