Bold fonts not properly rendered

I'm using Source Code Pro, and if I have Draw bold text in bold font enabled, it looks completely different to any bold version of Source Code Pro that I can find. It looks like the Draw bold text in bold font option actually doesn't use a bold font, but instead smears the normal font out horizontally. You can see this for example on the F's in the examples below. The horizontal lines in the F are as thin in the Draw bold text in bold font version as in the normal font. In all bold versions they are thicker.

This is with Draw bold text in bold font enabled:

This is with Source Code Pro:

This is with Source Code Pro Medium:

This is with Source Code Pro Semibold:

This is with Source Code Pro Bold:

This is with Source Code Pro Black:

I'm using build 2.9.20160206 on OS X 10.11.3.

My settings: com.googlecode.iterm2.plist

Milestone changed to Ship 3.0

Can you make sure you have the latest version of Source Code Pro Regular and Source Code Pro Bold installed? After installing both I got proper rendering. The horizontal smear happens if we can't find the bold version of the regular font. Here's a bold and regular version of "F" on my system:

In commit 41325364 I added some extra logging. If the problem persists after installing the newest version of these fonts, please do this:

1. Install the nightly build from https://iterm2.com/nightly/latest (but no earlier than Mar 13, about 5 hours from now, because the change hasn't been incorporated yet)
2. Select the menu item iTerm2 > Toggle Debug Logging
3. Create a new tab that uses the Source Code Pro ton
4. Select the menu item iTerm2 > Toggle Debug Logging
5. Attach /tmp/debuglog.txt to this issue.

I still seem to have the problem using the latest version of Source Code Pro. Debug log as requested: debuglog.txt

With Draw bold text in bold font checked: With Source Code Pro Semibold selected:

Versions:

• Source Code Pro from https://github.com/adobe-fonts/source-code-pro/releases/tag/2.010R-ro/1.030R-it
• iTerm2 Build 2.9.20160314-nightly

Can add that Source Code Pro show up correctly in the Font Book with all versions:

Please try tomorrow's nightly build (will be built in about 90 minutes). If it still doesn't work, please make a new debug log with it as directed above.

---

Note to self: the relevant part of the log is this. It proves we can find Bold, but regular doesn't turn into a font with the BOLD flag set in its traits. Commit 61f88e2a makes us less picky about which flags are set.

1458058512.559038 PTYFontInfo.m:38 (-[PTYFontInfo computedBoldVersion]): Bold version of "SourceCodePro-Bold 12.00 pt. P [] (0x7fb2df52f9d0) fobj=0x7fb2db4b83a0, spc=7.20" is "SourceCodePro-Black 12.00 pt. P [] (0x7fb2dcc944d0) fobj=0x7fb2df071be0, spc=7.20"
1458058512.563692 PTYFontInfo.m:41 (-[PTYFontInfo computedBoldVersion]): Failed to find a bold version of "SourceCodePro-Regular 12.00 pt. P [] (0x7fb2dcc85d60) fobj=0x7fb2df025ba0, spc=7.20"

Seems it now properly selects another Source Code Pro font, although this time it goes from Regular to Medium which is almost no bolding at all. Would it be possible to have a preferred list of variants that are selected first? E.g. first Bold if it exists, then anything with bold in it and only then the next font in the list?

New log running the latest nighty: debuglog.txt

Thanks for all the work btw!

I should've figured that out before, but we don't want to pick the first heavier font we find--we need to use one that's relatively bolder by the right amount. Fixed in commit 96d690cd. Please try tomorrow's nightly build.

Status changed to closed

Can confirm this works in the latest nightly. Thanks so much!