Cmd-click regression in recent 2.9 beta build: triggers downloads instead of opening file in editor

• iTerm2 Build 2.9.20160206
• Mac OS X 10.11..3
• com.googlecode.iterm2.plist

I recently updated to the latest 2.9.x build (was using an older build, perhaps 1-2 months old, before that -- sorry, don't remember which exactly).

Since then, the super-cool and useful "Cmd-click" feature that allows you to click on a file or path and open it in an editor is semi-broen for me, and so far I couldn't figure out how to restore it.

As a typical example, suppose I have this in my terminal:

~/Projekte/foreign/git-remote-hg/hg-versions/mercurial-3.7.1 (git:master)$ ag deprecated
contrib/check-config.py:66:            m = re.search(r'# (?:internal|experimental|deprecated|developer)'
contrib/pylintrc:199:# * uses of deprecated modules
contrib/pylintrc:204:deprecated-modules=regsub,TERMIOS,Bastion,rexec
doc/hgrc.5:760:(defaults are deprecated. Don\(aqt use them. Use aliases instead.)
doc/hgrc.5:1525:(deprecated) The URL or directory for the default \%\fBhg push\fP\: location.
doc/hgrc.5.html:579:<p>(defaults are deprecated. Don't use them. Use aliases instead.)</p>
...

Then if I press the Cmd-key and hover over the filenames, I would expect it to highlight e.g. contrib/check-config.py:66, and, upon a click, open my editor at that file and line.

Instead, it highlights just py:66, and clicking then starts a "download". A feature I never noticed before, which has zero value for me, but for which I also couldn't figure out a way to turn it off.

Any help would be greatly appreciated.

Thank you very much for iTerm2, it's a great piece of software.

OK, weird tidbit: I just opened a new tab in the same directory, and there it works. I can switch back and forth between the two tabs, and reproducibly, in one it "works", in the other it doesn't. Note that the first tab was also only opened a few minutes ago, so I am fairly certain no settings were changed in between the creation of the two tabs.

Please make a debug log in the tab where it doesn't work. Instructions are at https://iterm2.com/debuglog.

I brought one of the affected tabs to the front, and activated tab logging. Not quite sure what I am then supposed to do next, so I guessed, and first did a cmd-click on a filename (which started a file download); then did the same search I did before again, and again tried a cmd-click on a filename.

debuglog.txt.bz2

Milestone changed to Ship 3.0

This keeps happening. Usually, I can "fix" it by opening a new tab, and executing the same command again.

@fingolfin Here's what I see:

You clicked on lib/pslq.gi:133

Your working directory was /Users/mhorn/Projekte/GAP/repos/pkg/ace.

No file exists with the path name /Users/mhorn/Projekte/GAP/repos/pkg/ace/lib/pslq.gi, so it failed to open anything.

Is it true that no such file existed? Was the working directory wrong?

The working directory was .../float not .../ace -- but just before that, it was indeed .../ace, see the attached screen shot.

Note that I get this error a lot, and the workaround I use is to press Cmd-T to open a new tab; I set iTerm2 to open new tabs in the same directory as the active tab. And that works in all those cases, i.e. for that, iTerms2 seems to know exactly what the CWD is.

BTW, I closed the "original" tab for which I made this report by now. But I just tried a grep in a random open tab, and immediately could reproduce the issue. So if you have any tests I should run, I should be able to do that.

I presume you are doing all this locally on your mac, not over ssh. Please let me know if that is not true.

I've made a special build that has extra debug logging. Please do this:

1. Install this version of iTerm2: http://iterm2.com/adhocbuilds/iTerm2-2_9_20160228_120000-adhoc.zip
2. Start debug logging
3. Start reproducing the bug, beginning with the cd ../float/ command.
4. Cmd-click on gi:134
5. Stop debug logging
6. Attach debug log here.

You are correct, all of this is locally.

And I did as you asked (below), but your question made me realize that so far the issue only happened after a "cd", but not if I open a fresh tab in the same directory. That made me suspect shell integration. So I downloaded a fresh copy of .iterm2_shell_integration.bash and noticed that it contains a lot of differences. I moved my old version aside, and installed the new version. So far I couldn't reproduce the issue with that (but I'll give it a bit more time).

It would be really helpful if that file contained a "last changed date" at the top.

Also, perhaps iTerm2 could somehow check whether an outdated version of shell integration is installed? (Perhaps the shell integration could set some env variable to a version or date string, which iTerm2 could check?)

Finally, here's the answer I typed before making the above discovery:

Here you go. However, this time, Cmd-Click did not even highlight the "gi:134" or anything. I tried multiple times, also with other search terms etc. -- nothing. But when i went back to ../ace, it worked. Then I go to float, it stops working.

I should emphasise that this problem also occurs in other directories. And if i use Cmd-T to open a new tab in the right directory, the issue goes away.

debuglog.txt.gz

There've been a lot of bug fixes, so I think it may well have been fixed.

It does have a version number but I'm reluctant to bump without a really compelling reason (like a security issue) because it'll be so annoying for users who may not even be aware of minor bugs. Maybe I'll bump the version number when 3.0 goes final, though—that feels justifiable.

Status changed to closed

Bumping the version once 3.0 goes final would be really good -- otherwise, those people who did the beta testing are punished for that (they suffer for using a beta version of that script, without any hints anywhere that there is an update of the script available).

I opened #4370 (closed) for this.