Bug: Closing a tab with Toolbelt present causes the Toolbelt window to close and resize it's elements much wider

Build 2.9.20160206

com.googlecode.iterm2.plist [debuglog.txt] (/uploads/fc158b9c2821b40813834bffaf9d38df/debuglog.txt)

Reproduction:

1. Open a couple tabs
2. cmd+shift+B to show Toolbelt
3. Close one of the tabs, this causes Toolbelt to "slide" off the right

To get Toolbelt visible again you have to click on the very rightmost line where you can still see a strip of white. Once you move the Toolbelt window to be visible again the buttons are off-center as if they think the window is much larger than it is.

It seems like your window is bigger than the monitor it is (mostly) on. Is this correct, and is that required for the bug to occur?

Milestone changed to Ship 3.0

That's what it "feels" like is happening but the edges are inside the viewable monitor. I am using Spectacle (https://www.spectacleapp.com) and just hitting cmd+option+f to full size it and I can clearly see the boarders on the screen still. Moving my mouse cursor to the edge lets me resize it so the parent (iTerm2) window is not shifted past the boundaries. Would a screen video capture help? Was there anything else I can gather logging wise?

Yeah, a video would help.

Also, just to be sure, can you try turning off Spectacle? I wonder if it's trying to mess with the window size at a bad time.

Recreated it with Spectacle closed. As far as I know it doesn't do anything automatic with window resizing unless you hit the hotkey.

The video is 100mb and this is limited to 10mb but here's a little more specific recreation steps.

1. Open iterm and expand the window size to the right edge of the screen.
2. I open about 8 tabs (cmd+t x 8)
3. Hit cmd+shift+b for toolbelt.
4. Expand toolbelt to the left a little ways (like double or triple default width)
5. Hit cmd+w to close one of the tabs (Doesn't seem to matter which tab)
6. Toolbelt then slides off the right side.
7. Grab toolbelt edge from right side and it can be dragged to the left to show elements however they are now off center.

If that still doesn't work let me know if there's a preferred place to host the video.

I made a special build with more debug logging. Please do this:

1. Install http://iterm2.com/adhocbuilds/iTerm2-2_9_20160301_200257-adhoc.zip
2. Start debug logging (iTerm2 > Toggle debug logging)
3. Reproduce your steps, but don't do the last one
4. Stop debug logging (iTerm2 > Toggle debug logging)
5. Attach /tmp/debuglog.txt to this issue.

debuglog.txt

Ok I see better what's happening now. There seem to be two Toolbelt scenarios:

1. If I have a window that has more available screen space to the right side of it than the Toolbelt size the window will increase in size to include its current size + default size of Toolbelt.
2. If I have the window against the right edge of the screen the Toolbelt will take up some of the window size but respect/stay inside the visible screen/current window dimensions.

With scenario 2 setup, if I close a tab it looks like during the redraw it is not keeping track that it's on the edge of the screen so the next tab over's viewable area gets expanded back out to the edge of the screen but Toolbelt is still open and it also gets then redrawn + window expanded outside the screen. If I drag the window back to the left I see Toolbelt there properly sized it was just being redrawn outside viewable area.

Let me know if that capture got the info correctly.

Thanks for that. It helped me narrow down what's going on, but I still can't explain why the tab got resized to be larger. I think you're right about the toolbelt moving offscreen, but that's not the whole picture. I added some more logging; can you do it again with this build:

http://iterm2.com/adhocbuilds/iTerm2-2_9_20160303_212021-adhoc.zip

Thanks! I hope this is the last iteration.

Alright no problem George, it only takes a minute to do. Here's the latest log. debuglog.txt

I was finally able to reproduce. The steps I followed are:

1. Create a new window. The toolbelt is not visible initially.
2. Add two more tabs, totaling three. It does not reproduce with only two tabs.
3. Show the toolbelt
4. Make the toolbelt wider by dragging its handle left.
5. Close the current tab

I don't know why I couldn't do it before, this is close to the original report. Anyway, it looks like when the toolbelt gets resized not all PTYSplitViews get resized.

Fixed in fa87c988.

Status changed to closed