copying text in tmux horizonally split window includes trailing whitespace in left pane (but not rightmost pane)

in a tmux session, split horizonally: copy multiline text on the right pane and paste it somewhere: it shows lines without trailing whitespace in each line

but for the left pane: it shows trailing whitespace and now newline, as one long line:

line1......line2.......line3.....

instead of:

line1
line2
line3

NOTE: this is a different bug form https://gitlab.com/gnachman/iterm2/issues/3780 which occurred in tmux copy mode

on a (related?) note, function _getTextInWindowAroundX seems unused

on a related note again:

as a workaround for https://gitlab.com/gnachman/iterm2/issues/3780, when I join lines from a text that's supposed to be a single line but was split in multiple lines due to tmux inserting hard newlines in copy mode, I sometimes get wrong results:

suppose i have:

word1 word2 word3 word4 word5 word6

which tmux wraps into:

word1 word2 wor\n
d3 word4 word5 \n
word6

Copying this in tmux gives:

word1 word2 wor\n
d3 word4 word5\n
word6

which, when applying join-lines, gives the wrong result:

word1 word2 word3 word4 word5word6

I traced it down in your code to this:

(includeLastNewline || line < windowedRange.coordRange.end.y)) {
if (trimSelectionTrailingSpaces) {...}

commenting out the block

if (trimSelectionTrailingSpaces) {...}

makes it work

looks like relying on tmux clipboard handling instead of iterm's logic (which can't have as much info as tmux) solves these kind of issues: https://plus.google.com/+YuriyNemtsov/posts/NiRiDkTcvS8

CAVEAT: this requires setting option ON for "Applications in termnial may access clipboard"; which poses a security risk; is there a way to limit this access to a trusted one (eg tmux) via a whitelist?

That looks like the best solution to this problem.

Status changed to closed