Updater doesn't restore session

Restoring sessions (windows, tabs, split panes, bash "locations") works fine when doing an OS restart. It doesn't work when iTerm suggests installing an update, instead it opens a single window with a single tab and a new default session.

• iTerm2 version: Build 2.9.20160523
• OS version: 10.11.4
• Attach ~/Library/Preferences/com.googlecode.iterm2.plist here: com.googlecode.iterm2.plist
• Attach a debug log (https://iterm2.com/debuglog) - can't do this, since I just installed the update

Changed title: Update install doesn't restore session → Updater doesn't restore session

I was only able to reproduce this when I had two copies of iTerm2 running at once, but there are a lot of variables at play here.

Can you try this special build of iTerm2 and let me know if it helps?

http://iterm2.com/adhocbuilds/iTerm2-1_9_20160528_120720-adhoc.zip

Its version number is set to 1.9 so it will always update.

i've been hitting this in 100% of the updates in the last few months. the only kind of workaround is to manually save a window arrangement before update and restore it after. that doesn't restore the scrollback buffers though.

i'm now at 3.0.5. anything i can do to help debug?

@todorb First, make sure System Prefs > General > Close windows when quitting an app is turned off and Prefs > General > Startup is set to Use system window restoration setting.

Assuming that's ok, you can make a debug log by turning on Prefs > Advanced > Start debug logging automatically when iTerm2 is launched. Then reproduce the issue by updating. Then turn off debug logging to write the debug log to /tmp/debuglog.txt. You can use the build linked to above to test with since it'll always update.

"Close windows when quitting an app" was on for me. everything is good when it's turned off. thanks!

is it possible to detect the value of this setting and show a warning on the updater dialog that the session will not be restored?

Milestone changed to %Feature Complete 3.1

I'll look into this. I think all I can do is display a modal dialog just before updating, using this delegate method:

- (BOOL)updater:(SUUpdater *)updater shouldPostponeRelaunchForUpdate:(SUAppcastItem *)item untilInvoking:(NSInvocation *)invocation;

changed milestone to %Review for next version