iTerm freezes when process crashes during image display

c.f. https://github.com/Keno/TerminalExtensions.jl/issues/16

If the process crashes (or the SSH connection drops, etc.) after it indicated it would send image data, iTerm2 will keep waiting for it and it's almost impossible to get the terminal back. I'm not entirely sure what I'm asking you to do here, I guess leave error mode if a non-base64 character is encountered or maybe even after a (long-ish) timeout.

This is rarely a problem because another escape sequence will cause it to be aborted, and most people have fancy prompts with escapes in them nowadays. Could this Julia extension catch sigsegv and write esc[m (as an example of a harmless escape sequence that will break iTerm2 out of image processing)?

Yes, it could, but that's not a general solution, because there is a ton of ways things can go wrong that can't be caught, e.g. OOM, SIGKILL, SSH connection drop.

Maybe the thing to do is this: if we detect typing while downloading an image, ask the user if they want to abort the download.

Milestone changed to %Feature Complete 3.1

We'll show a butterbar announcement asking to cancel the download if you press control-C. Commit 561f4115.

closed