Render the selected match from search more vividly

Thanks for filing an issue! Please answer the questions below so I can help you.

• iTerm2 version: 3.0.13
• OS version: 10.12.3
• Attach ~/Library/Preferences/com.googlecode.iterm2.plist here (drag-drop from finder into this window) com.googlecode.iterm2.plist

Detailed steps to reproduce the problem:

1. Open a terminal window and generate some text. Could simply be by typing. Make sure to type a number that is at least 3 digits long (e.g. "12345").
2. Press command-f and type a numbers-only string that should find a match (e.g. "12345")

What happened: The matching string is found, but it is highlighted using the "selected text" styling.

What should have happened: It should have been highlighted in bright yellow. If you search for fewer than 3 numbers (e.g. "12"), or a string with letters, you get the right result.

I went to try to make screenshots to add to the bug report and was not able to immediately reproduce. I've seen this a lot though. I think there may have to be a minimum amount of text in the window to trigger it. In this example: ...the string "172" is in the third-last line. It has a slightly different green background color.

In this example: ...I searched for "17" instead. You can see three examples of proper yellow highlighting. But if you look at the same "172" in the third-last line, you'll see the 17 has the slightly different green background color instead of the yellow.

Really odd.

changed title from Find command does not correctly highlight matches if search string is 3+ numeric characters to Find command does not correctly highlight matches for some numeric search strings

The reason it's in a green color is because the first match is automatically selected. I suppose it ought to be rendered differently, though, since standard textviews on macOS really call it out.

changed milestone to %Review for next version

changed title from Find command does not correctly highlight matches for some numeric search strings to Render the selected match from search more vividly

Ah. You're considering match order to be closest to the end? Standard Mac convention is to start at the top. If the "find again" order is also reversed, meaning the next match is the second to last, I suppose that's reasonably logical given the nature of a terminal.

Thanks for looking into this!

Yes, the order is intentionally reversed.